Repository navigation
Conversation
5 of 7 tasks
Co-authored-by: cbartz <4182921+cbartz@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Address feedback on Prometheus-based Grafana dashboard
Replace hardcoded Prometheus datasource UID with template variable
Nov 11, 2025
cbartz
reviewed
Nov 11, 2025
Comment on lines
+1514
to
+1536
| { | ||
| "current": { | ||
| "selected": true, | ||
| "text": [ | ||
| "All" | ||
| ], | ||
| "value": [ | ||
| "$__all" | ||
| ] | ||
| }, | ||
| "hide": 0, | ||
| "includeAll": true, | ||
| "label": "Prometheus datasource", | ||
| "multi": true, | ||
| "name": "prometheusds", | ||
| "options": [], | ||
| "query": "prometheus", | ||
| "queryValue": "", | ||
| "refresh": 1, | ||
| "regex": "", | ||
| "skipUrlSync": false, | ||
| "type": "datasource" | ||
| }, |
Collaborator
There was a problem hiding this comment.
@copilot please remove this template, the prometheus datasource has been defined by the pr
Contributor
Author
There was a problem hiding this comment.
I can remove the template variable, but what should the datasource UID references be changed to instead of ${prometheusds}? Should they be:
null(to use default datasource)"$__all"- A specific UID that the PR provides
- Something else?
The original feedback requested replacing the hardcoded PE6731821AF182E02 with a template variable, so I want to make sure I use the correct approach.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable spec: N/A
Overview
Replaces hardcoded Prometheus datasource UID in
metrics_prometheus.jsonwith a template variable to enable dashboard portability across Grafana instances.Rationale
The dashboard contained 32 hardcoded references to
PE6731821AF182E02, preventing reuse in different Grafana environments. Template variable approach matches existing pattern inmetrics.json.Juju Events Changes
None
Module Changes
None
Library Changes
None
Checklist
urgent,trivial,complex).github-runner-manager/pyproject.toml.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.