Skip to content

[WIP] chore: refactor integration tests - #649

Closed
yanksyoon wants to merge 1 commit into
mainfrom
chore/integration-test-refactor
Closed

yanksyoon wants to merge 1 commit into
mainfrom
chore/integration-test-refactor

Conversation

@yanksyoon

Copy link
Copy Markdown
Member

Applicable spec:

Overview

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

  • The charm style guide was applied.
  • The contributing guide was applied.
  • The changes are compliant with ISD054 - Managing Charm Complexity
  • The documentation for charmhub is updated.
  • The PR is tagged with appropriate label (urgent, trivial, complex).
  • The changelog is updated with changes that affects the users of the charm.
  • The application version number is updated in github-runner-manager/pyproject.toml.

@yanksyoon

Copy link
Copy Markdown
Member Author

@copilot Phase 1, PR 1: Create fixture module structure for integration test refactoring


Following the integration test refactoring plan in .github/copilot-instructions/integration-test-refactor.md, implement Phase 1, PR 1: Create the foundation fixture module structure.

Tasks from the instruction file:

  • Create tests/integration/fixtures/ directory
  • Create tests/integration/fixtures/__init__.py with basic imports
  • Create tests/integration/fixtures/applications.py with module docstring for Juju application fixtures
  • Create tests/integration/fixtures/github.py with module docstring for GitHub API fixtures
  • Create tests/integration/fixtures/openstack.py with module docstring for OpenStack resource fixtures
  • Create tests/integration/fixtures/mongodb.py with module docstring for MongoDB and queue fixtures

Expected outcome:

  • 5 new files created with proper module structure
  • Basic imports and docstrings in place
  • Foundation ready for Phase 1, PR 2 (extract application fixtures)

This is the first step in the 10-PR incremental refactoring plan. Low risk - no existing functionality changed.

@yanksyoon

Copy link
Copy Markdown
Member Author

Doesn't work, closing.

@github-actions

github-actions Bot commented Nov 5, 2025

Copy link
Copy Markdown
Contributor

TICS Quality Gate

❌ Failed

The following errors have occurred during analysis:

❌ [ERROR 5333] Project database 'github-runner-operator' already is connected to a started TICSQServer process that has not registered a stop time. To avoid data corruption, analysis is aborted. Details of the other TICSQServer process: started at 2025-07-09 14:32:08.000 by user ubuntu.

.github/workflows/tics.yaml / TICS / TICS GitHub Action

@yanksyoon yanksyoon closed this Nov 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants