[yhaliaw]

Applicable spec:

Overview

Rework the automatic restart of the github-runner-manager.

• Remove the restart limit posed by StartLimitIntervalSec.
• Use the systemd restart configurations to add 30 seconds wait between restart with a backoff to 10 mins for repeated failures after 5 times.

Rationale

We have observe the StartLimitIntervalSec was being triggered when the network is very unstable.
This cause the systemd to not restart the github-runner-manager service.

Checklist

• The charm style guide was applied.
• The contributing guide was applied.
• The changes are compliant with ISD054 - Managing Charm Complexity
• The documentation for charmhub is updated.
• The PR is tagged with appropriate label (urgent, trivial, complex).
• The changelog is updated with changes that affects the users of the charm.
• The application version number is updated in github-runner-manager/pyproject.toml.

The change should be transparent to the users.
The application is not updated in this PR.

[yhaliaw]

Currently, integration test with juju deploy containers fails.
@weiiwang01 has tracked this down to a kernel issue.
For now, I think we will wait for a upstream fix.

[yanksyoon]

LGTM!

[Copilot]

Pull Request Overview

This PR configures systemd restart behavior for the github-runner-manager service to handle network instability more gracefully. The key change removes the restart limit and implements a progressive backoff strategy that starts with a 30-second delay and extends up to 10 minutes after 5 consecutive failures.

Key Changes:

• Removed restart limit (StartLimitIntervalSec=0) to prevent the service from permanently stopping during network instability
• Added restart backoff configuration with 30-second initial delay, 5-step progression, and 10-minute maximum delay
• Minor code formatting and linting improvements

Reviewed Changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/manager_service.py	Added systemd restart configuration with backoff strategy
tests/integration/conftest.py	Reformatted function call for consistency
pyproject.toml	Added pylint good-names configuration
github-runner-manager/pyproject.toml	Added pylint good-names configuration and removed blank line
.github/workflows/docs.yaml	Removed trailing blank line

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[cbartz]

LGTM