Repository navigation
chore: migrate terraform modules to CC008 - #129
Merged
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
weiiwang01
marked this pull request as ready for review
October 15, 2026 04:46
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…/product layout Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Copilot review overview
2 open findings
What changed in this PR
Migrates the Terraform module layout and CI to align with the CC008 Charm Terraform Standard, including updated module interface and workflows.
Changes:
- Introduces CC008-style module outputs (
application/provides/requires) and adds aconstraintsinput. - Moves/creates CC008 Terraform tests under
terraform/charm/testsand updates CI workflows for compliance, testing, release, and docs generation. - Updates documentation and repository config (README, changelog, gitignore, license config) to reflect the new module structure.
| File | Description |
|---|---|
| terraform/versions.tf | Updates Terraform and Juju provider version constraints. |
| terraform/variables.tf | Adds CC008-required inputs (constraints) and adjusts nullability/defaults. |
| terraform/main.tf | Wires new constraints variable into the Juju application resource. |
| terraform/tests/setup/main.tf | Updates test setup Terraform/provider versions and makes test model name unique. |
| terraform/tests/main.tftest.hcl | Removes old root test file (tests moved under terraform/charm). |
| terraform/tests/integration/main.tf | Removes old integration test module. |
| terraform/tests/integration/wait-for-status.sh | Removes external-script-based status polling for old tests. |
| terraform/outputs.tf | Removes deprecated outputs (app_name, endpoints). |
| terraform/charm/tests/main.tftest.hcl | Adds CC008-style tests targeting the terraform/charm module. |
| terraform/charm/outputs.tf | Adds CC008-style outputs (application, provides, requires). |
| terraform/charm/MAJOR_VERSION | Adds MAJOR_VERSION file for charm module path. |
| terraform/README.md | Updates docs to reference CC008 module path/outputs and adds terraform-docs markers. |
| terraform/MAJOR_VERSION | Introduces module major version file at terraform/. |
| docs/changelog.md | Documents the CC008 migration and interface changes. |
| .licenserc.yaml | Exempts **/MAJOR_VERSION from license header checks. |
| .gitignore | Updates Terraform ignore patterns (including lockfile). |
| .github/workflows/test_terraform_modules.yaml | Adds new Terraform module test workflow using pinned operator-workflows. |
| .github/workflows/test_terraform_module.yaml | Removes old Terraform module test workflow. |
| .github/workflows/terraform_modules_release.yaml | Adds Terraform module release workflow using pinned operator-workflows. |
| .github/workflows/terraform_modules_compliance.yaml | Adds Terraform module compliance workflow using pinned operator-workflows. |
| .github/workflows/generate_terraform_docs.yaml | Adds workflow to auto-generate Terraform docs for terraform/charm. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Copilot stopped reviewing on behalf of
florentianayuwono due to an error
October 15, 2026 12:48
florentianayuwono
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Migrate Terraform modules to the CC008 standard