feat: chore(prompts): formalize cross-prompt contract registry for develop + research machines - #323
Closed
canesin wants to merge 4 commits into
Closed
feat: chore(prompts): formalize cross-prompt contract registry for develop + research machines#323canesin wants to merge 4 commits into
canesin wants to merge 4 commits into
Conversation
sync dev commits
* chore(wip): checkpoint [skip ci] * fix: use login shell in runShellSync fallback for full user PATH Change bash -c to bash -lc in the runShellSync fallback path so that user profile additions (go, cargo, etc.) are available when the MCP server runs from a non-login context (systemd, VS Code, Claude Code). Closes #306 * fix: pre-review cleanup — correct cmd field to match -lc flag
Owner
Author
|
Closing to redo from current dev — rebase conflicts with #321 were too entangled to preserve cleanly. Will reopen a fresh PR on a new branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#322: chore(prompts): formalize cross-prompt contract registry for develop + research machines
Metadata
Problem
Prompt builders in the develop and research workflows use independent string literals to define section headings (e.g.
Required sections (in order): ...inplan-review.machine.js). Consumer machines likeimplementation.machine.jshardcode these identical names when instructing the agent on what sections to process (e.g.Step 1: Address Critique). Because these lists are disconnected, renaming or adding a section in a producer prompt can silently break the consumer, causing the agent to skip sections. Additionally, hardcoded parsers (parsePlanVerdict,parseReviewVerdict) break silently or fall back incorrectly if the heading names they search for change. There is currently no shared source of truth enforcing that producer headings, consumer instructions, and parser regexes stay in sync.Closes #322