Skip to content

Update vocs.py - #68

Open
roussel-ryan wants to merge 3 commits into
mainfrom
bounds-update
Open

Update vocs.py#68
roussel-ryan wants to merge 3 commits into
mainfrom
bounds-update

Conversation

@roussel-ryan

Copy link
Copy Markdown
Collaborator

This pull request introduces improvements to how variable bounds are computed in the gest_api/vocs.py file, making the bounds property more robust for both continuous and discrete variables.

Enhancements to variable bounds calculation:

  • Updated the bounds property to handle both ContinuousVariable and DiscreteVariable types. For discrete variables, it now attempts to convert values to numeric bounds and raises a clear error if non-numeric values are encountered.

@roussel-ryan
roussel-ryan requested review from jlnav and shuds13 June 8, 2026 18:31
@codecov

codecov Bot commented Jun 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (cf08a3e) to head (618fe06).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #68   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          599       624   +25     
=========================================
+ Hits           599       624   +25     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jlnav

jlnav commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

Could this be implemented only for those DiscreteVariables that are float-castable? Perhaps not all discrete options belong as part of a bounds determination?

@roussel-ryan

Copy link
Copy Markdown
Collaborator Author

Good point, ill add logic to make sure that the discrete values are numeric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants