Update vocs.py - #68
Open
roussel-ryan wants to merge 3 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 5 5
Lines 599 624 +25
=========================================
+ Hits 599 624 +25 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
Could this be implemented only for those DiscreteVariables that are float-castable? Perhaps not all discrete options belong as part of a bounds determination? |
Collaborator
Author
|
Good point, ill add logic to make sure that the discrete values are numeric |
jlnav
approved these changes
Jun 24, 2026
shuds13
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces improvements to how variable bounds are computed in the
gest_api/vocs.pyfile, making the bounds property more robust for both continuous and discrete variables.Enhancements to variable bounds calculation:
boundsproperty to handle bothContinuousVariableandDiscreteVariabletypes. For discrete variables, it now attempts to convert values to numeric bounds and raises a clear error if non-numeric values are encountered.