Repository navigation
Another round of security fixes - #68
Merged
Merged
Conversation
- Don't set inShell for non-PTY `ssh host cmd`, so Ctrl-C still cancels the context and closes the connection when a remote command hangs. - Remove deleted or replaced keys from the SSH agent even when the agent is locked (keys delete/generate/import/discover), and reset the agent lock state on db wipe and db restore. - Report an invalid preset host key without aborting the rest of the preset config. - Build the v2->v1 downgrade test case from the untampered key bytes so it actually exercises the version downgrade path. - Return the cached stream helper before touching the service worker, and drop the unused UnregisterServiceWorker. - Return the parsed client data from verifyClientData instead of parsing ClientDataJSON twice in Sign. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This round is provided by Gemini 4 Argon and reviewed by Claude Fable 5.1
🔒 Security fixes
ValidBefore == 0as expired, while continuing to acceptssh.CertTimeInfinity(0xffffffffffffffff).-cannot inject command flags, and strip directory components from uploaded local file names.CTRL-ALT-Wtriggersdb wipe, and only process keyboard shortcuts at the top-levelsshterm>prompt.db wipe,db restore,keys delete,keys generate,keys discover, andkeys import, even when the agent is locked.db wipeanddb restorealso reset the agent lock.config.json'shosts[].key. The error is reported and the remaining preset config is still applied.WebAuthn.Create, and enforce a minimum of 1,000 PBKDF2 iterations on encrypted WebAuthn keys and database backups.keys show, and error messages in the host-key prompt, and strip 8-bitCSI(\x9b) characters from pasted text.🔧 Bug fixes
agent remove <name>for WebAuthn (ecdsa-sk) keys and deleted keys, and avoid holding the agent lock while fetching user certificates from an identity provider.caTrustedForand host-certificate trust updates when the hostname includes a:portsuffix (such as jump hosts).db restorewhen restoring empty maps, keys with identity providers, or backups withpersist: false, and respectconfig.json'spersistsetting.sftp getworking across multiple screens when one screen exits.autoConnectfrom overwriting keys and settings saved by other open tabs.Ctrl-C, and reject negative file sizes in ZMODEMZFILEheaders.js.Funccallbacks acrosswebsocket,terminal,jsutil,indexeddb,sftp, andapp.