Repository navigation
feat(tasks): add versioned briefings, collaborators and task dependencies - #620
Merged
Merged
Conversation
PeterGuy326
previously approved these changes
Oct 21, 2026
PeterGuy326
approved these changes
Oct 21, 2026
This was referenced Oct 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Project task runs now receive a server-owned statement of the goal, task, acceptance criteria and declared collaboration context. Tasks with predecessors stay blocked until current execution/delivery evidence supports human acceptance or explicit manual completion. Reviewers can inspect the exact saved model requirements separately from current project state.
Closes #619. Closes #621. Includes the collaboration implementation merged through #622. #618 has merged into
main. This PR now targetsmainand delivers phases 2a and 3 together.Behavior and acceptance
task-briefing.v1payload before invoking the model. Terminal/reopened records retain exactly the injected requirements, byte count, digest and execution identities.Scope is executable project work items. Employee reviewer dispatch (phase 2b), live negotiation, automatic scheduling and other task stores remain separate work. Recording a reviewer does not execute an employee review or confer acceptance authority.
Validation
The reviewed integration head
f1fe7c3d59889dc9771f972627b1629b621b2579has the same complete source tree as #622's tested headbc7950c8c8e89647bb24979eba45bbd5c2830729. PeterGuy326 approved that integrated feature head. Retargeting from the phase-one branch tomaindismissed the earlier approval. PeterGuy326 renewed approval on final headd2d42b303578904b3f58caf7208db01caddc25bdat 2026-10-21 06:37:23 UTC, and all current-base checks passed before merge.Feature validation already completed: TypeScript build, updater preparation, UI/renderer type checks; 233 script/runtime tests; 53 UI tests; complete server suite 987 passed/4 skipped; all 1,262 renderer tests across 89 files; Vite 6.4.4 production build and 570 desktop-main tests; dependency audit with 0 vulnerabilities;
git diff --check. Native macOS/Windows staging, unsigned installers, layout parity and security checks passed for that reviewed integration head. Final integration headd2d42b303578904b3f58caf7208db01caddc25bd: all fresh GitHub checks passed against current main, including both Node 24 full suites, CodeQL, dependency review, OpenSSF Scorecard, both platform staging/installer checks and layout parity. Fresh independent approval by PeterGuy326 was received on that exact final head after retargeting. The main-merge conflict resolution preserves the independently precomputed combined source tree; the sole additional cleanup removes an existing conflict-marker line from main's CHANGELOG. No feature behavior was changed by integration.Tests cover authoritative readiness, old-writer preservation/clearing, DAG/API rejection, group/bare bypass prevention, failed evidence reads, running/saved/injected equality, restart/retry/approval binding, filtering, snapshot tampering, budgets/source deduplication, editor persistence, current-vs-saved review and reconnect refresh. No coverage percentage is claimed.
Local checks used supported Node 22.23.2; repository CI uses Node 24. The shared root container's narrow ephemeral-port range and DAC overrides require this isolated server-test invocation, without changing host sysctls or assertions:
unshare --net sh -c 'ip link set lo up && setpriv --bounding-set=-dac_override,-dac_read_search node --test --test-concurrency=2 --test-timeout=120000 apps/server/dist/test/*.test.js'Browser plugin unavailable; installed Playwright/Chromium exercised real project components and local HTTP/SSE routes with a deterministic driver at desktop and 480-px narrow widths. Passed upstream completion-still-blocked → human acceptance → downstream execution; saved payload vs actual model input; source navigation; disconnect/reconnect after a new failed upstream; rejected bypass; immutable/current-state human review. Narrow drawer content/scroll widths were both 456 px. No unexpected browser errors; one expected 409 and a pre-existing Ant Drawer deprecation warning. Screenshots were inspected, and the complete flow passed again after the dependency-checkbox layout correction. This is product-flow evidence, not live-provider quality evidence. Full original ledgers remain in #622 and the linked design documents.
Compatibility and rollback
Deploy matching server, IPC and renderer. Existing records without briefing/collaboration snapshots remain readable, while configured collaborative tasks require the explicit current launch contract. Older strict readers may reject newly extended records: retain pre-upgrade backups or separate workspace data for downgrades. Do not erase historical snapshots or silently drop briefing fields to fabricate compatibility. Revert code to roll back. Filtering is best-effort; digests establish consistency, not authenticity or human approval.
Designs: project task briefings, task collaboration context.
Merged into
mainat 2026-10-21 06:40:03 UTC asb69b9d8a2a0271b0084e38670e1add22b1454640. The merge source tree exactly matches the verified final integration tree25e1b4831c0421b56d28ba1b32e4008db303104a. Issues #619 and #621 close with this merge.