[waterbro-8]

Summary

Approval aging overlay on pending items.

• Deterministic clock vs createdAt; expired vs pending still use existing clock helpers.
• Jev Choice nudge / wait / discuss-close is copy only.
• Overlay cannot hide pending high; needsAttention=false stays in the same rule-risk layer.
• No decision POST. Clicking the suggestion only opens the item.
• Server-side ranking is wired into the real GET /approvals projection; flag-off preserves original order.

Verification

• node --test apps/server/dist/test/approval-aging-overlay.test.js — 9/9
• package-layout runtime manifest + closed imports — 2/2
• renderer approval-queue.test.tsx — 29/29

Product tracking remains open: #422

Refs #466

[waterbro-8]

复审 exact head 88ef0abf77e2e591cf1e0e978a7d4334a0e3eb1b：aging overlay 已接入真实 GET /approvals projection；flag-off 保持原顺序，overlay 仅在同 rule-risk 层内重排，pending high 不隐藏；expired/actionable 仍由既有 clock helpers 判定；renderer 点击仅打开目标事项，不触发 approve/deny。

Hosted checks 当前 11/11 全绿，closingIssuesReferences=[]；正文已补 Refs #466 并继续用完整 URL 保持产品 tracking issue 开放。PR 已转 Ready，并正式请求 @Bindy-lbb / @PeterGuy326 独立审核。

当前 GitHub 身份是作者，只做技术收口，不自批、不自合。

[waterbro-8]

Independent technical recap (not an Approve). Author waterbro-8 is my identity — I will not Approve or merge.

Exact head 88ef0abf77e2e591cf1e0e978a7d4334a0e3eb1b unchanged. Required checks 11/11 green. closingIssuesReferences empty (Refs #466; #422 stays open).

Named criteria

• Provider boundary: Laya payload is only createdAt / now / decision.kind / risk. Extra keys throw. Description, target, turn bodies are not sent.
• GET/list sort: rankApprovalViews / presentAgingQueue sort inside a rule-risk layer (high then other). needsAttention cannot lift a medium above a pending high. Flag-off (no overlay) returns original order.
• No verdict: Overlay is copy (nudge|wait|discuss-close). Invalid/off/non-pending → undefined. catch fail-open. Clicking the card/suggestion uses existing onOpen; no decision POST from this overlay.
• Perf/race residual (not a verdict leak): list() Promise.all awaits attachApprovalAgingOverlay per row, so GET /approvals waits on N Laya asks. Each view() uses its own Date.now(); rank uses a later Date.now(). If Laya hangs, the list hangs. Ranking itself is deterministic given overlays.

No blocker on aging boundary / sort / no-verdict. Residual: list latency bound to Laya.

@Bindy-lbb @PeterGuy326 please independent-review this SHA.

#506
#422

[sun-970]

Independent review of exact head 88ef0abf77e2e591cf1e0e978a7d4334a0e3eb1b. Not product验收. I am not merging.

Verify 11/11 green. Aging overlay on pending approvals, suggestion-only.

Technical APPROVE of this SHA.

[PeterGuy326]

Current live status: DIRTY against main. Please rebase after the foundational overlay/receipt changes are settled, preserve deterministic approval state as authority and Laya aging output as advisory only, rerun exact-head CI/security, then request re-review. Old approval cannot carry over conflict resolution.

[PeterGuy326]

Re-reviewed after the conflict resolution push. Changes since the original approval: (1) merge of current main, resolving CHANGELOG by keeping both Unreleased entries and porting the aging-overlay tag into the new ApprovalDetail component that replaced ApprovalDetailDrawer on main; (2) test adaptation to the new approval-detail testid; (3) dev-only lockfile bump of vite to 6.4.4 to clear the npm audit high advisory (GHSA-698v-4r3x-3vcv) that broke the security:check step on every branch. Feature semantics unchanged: the aging overlay stays suggestion-only, payload is { createdAt, now, decision.kind, risk }, pending high is never hidden, clicking only opens the item. All 11 checks green.