[PeterGuy326]

Tracking record

Refs #422
Refs #428

Summary

RoleWeave's Jev proposals currently expose separate suggestions, but several inputs omit the task intent needed to make those suggestions useful. This product RFC defines three complete user flows: P0 attention inbox, P1 pre-send collaboration planning, and P2 delivery preflight. It specifies the minimum evidence, user actions, abstention behavior, data boundaries, and acceptance criteria for each.

This PR changes documentation only. It does not enable Jev, send task content to TypeSafe, implement the proposed flows, resolve existing code-review blockers, or establish product acceptance. Existing no-body restrictions remain in force; any future opt-in task summary needs a separately reviewed implementation and explicit permission for the selected payload.

Acceptance criteria

Acceptance criterion	Status	Implementation / evidence
Explain each user's problem, before/after flow, inputs, outputs and next action	Documented for review	docs/design/jev-collaboration-product-v1.md
Keep deterministic facts separate from model suggestions and define fail-safe behavior	Documented for review	RFC authority, abstention and acceptance sections
Distinguish current no-body input from proposed opt-in semantic input	Documented for review	RFC data boundary and per-stage input tables
Reuse existing issues and identify overlapping stacked PRs	Documented for review	RFC delivery/review map; inventory below
Define a baseline-controlled pilot without claiming unmeasured results	Documented for review	RFC pilot and metric definitions; outcomes remain NOT MEASURED

Validation ledger

Command or check	Expected	Actual	Evidence
git diff --check	No whitespace errors	PASS (exit 0)	Local diff
Read the complete RFC and verify repository-relative links	No missing local targets; clearly marked proposal scope	PASS; 236-line RFC reviewed, 14 acceptance IDs checked	Documentation review
Read current GitHub main and PR metadata	Separate main, development branches, review status and releases	Verified main 6ea0a27dddfec17b73aeb567606093c7e873753c; #423/#429 remain open	GitHub API snapshot, 2026-09-22
Credential/private-path pattern scan and acceptance-ID check	No private paths/key-shaped values; AC-01 through AC-14 present	PASS; no matches; 14 IDs present	Local documentation validation
Live Jev and end-to-end product acceptance	Required for future implementation	NOT VERIFIED — documentation-only PR; no API invocation or runtime change	Deliberately not claimed

Related review inventory

Snapshot on 2026-09-22; re-read heads and bases before any code change or merge.

PR	Current scope/state	Review handling
#423	Open; head 4e58e8e; base main; current head has changes requested	Existing implementation context; inspect actual cumulative diff and target branches; no claim that blockers are fixed
#429	Open; head 59151b5; base feat/422-jev-goal-health; current head has changes requested	Existing health UI context; contains stacked changes requiring scope review
#436–#441	Merged into the development stack, not directly into main	Review through actual remaining branch diffs; do not treat MERGED as released
#442	Merged into feat/428-goals-health-overlay-ui	Stale-goal proposal needs the deterministic-rule/product review described in the RFC

The proposal does not prescribe resetting or force-pushing a shared branch. Any cleanup must reconcile current ancestry, cumulative changes and author ownership first. #422 remains open.

Tests and coverage

• Tests added or changed: none; no runtime behavior changes.
• Coverage before / after: not measured; not applicable to this documentation-only change.
• Local build and application tests: not run; product acceptance and live Jev evaluation remain future work.
• Repository CI is reported separately from design review and product acceptance.

Change classification

• User-visible behavior
• Internal refactor or maintenance
• Documentation only
• Build, CI, dependency, or repository configuration
• Breaking change
• Security-sensitive change

Risk and rollback

• Documentation-only proposal; no API, persistent data, permission, dependency or deployment changes.
• Future semantic input and context sharing are explicitly subject to a separate approved contract.
• Rollback: revert this documentation commit. Existing execution and approval behavior is unchanged.

Breaking or security notes

None in this PR. The RFC identifies proposed future data boundaries; it does not authorize external transmission of conversation, tool or document bodies.

Author checklist

• The maintainer requested a product design and PR review package linked to the existing RFC.
• This branch starts from current main and is limited to the product RFC and its documentation changelog entry.
• Applicable documentation checks completed; recorded above.
• No regression test added because no executable behavior changes.
• Documentation and changelog updated; final diff reviewed.
• Diff checked for private data, credentials and unrelated changes; no matches in the documented pattern scan.
• This PR requests independent review; no merge or product acceptance is claimed.

Reviewer notes

@waterbro-8 @sun-970 please review this as the consolidated product proposal. Focus on the three user flows, whether each Jev judgment has enough input, deterministic alternatives, data consent boundaries, and measurable acceptance criteria. Record concrete changes needed before implementation.

For the existing implementation stack, preserve current change requests and verify the actual base/head relationship. An author follow-up on their own code is not independent approval. This PR does not request automatic approval, dismissal of earlier reviews, or merge.

[waterbro-8]

设计评审（文档-only head 4b0ef4515cae4f5912a22b385f967b70cc5fb18d）。不是产品验收，不是实现批准，不合入。不要 Closes #422 / #428。

对第 12 节的技术/产品边界意见：

1. 同意 P0 先做完整处理闭环，P1/P2 等数据契约冻结后再做。 当前主干 6ea0a27 无 apps/server/src/jev/，不能把层叠开发分支当已交付。
2. 同意规则风险优先、原始失败不隐藏、模型不写 goal.health/审批/组织、应用建议不自动发送。 这与已有代码 review 门禁一致。
3. 当前 no-body（status/errorCode）不足以支撑可衡量的 Jev 增量。 信息不足必须弃权并保留规则流程；不得靠扩大外发或拿掉基线提醒刷指标。P0 首版只对已有状态/错误码做有限分类。第 4 节「Windows 验收记录缺失」示例是 P2 语义，实现时不得当 P0 AC。
4. P1/P2 opt-in 契约实现前冻结。 字段白名单、长度、脱敏、保留周期、预览实际将发送的字段后再点本次请求。启用 Jev 总开关 ≠ 批准外发。契约冻结由产品负责人（胡）拍板，实现 PR 我按 fail-closed 复审。
5. #423 / #429 不能当 P0 实现基线（现有 REQUEST_CHANGES 保留，本 PR 不解除）：
   • #423 head 4e58e8e 把 #436–#441 又 squash 进 insertion #1，应回到 insertion-1-only（先前 d00538f），需要的话 rebase 到当前 main。#423
   • #429 head 59151b5 混进 #442/#435 stale overlay，Story 1 应回到 7abe19a；stale 留在 #442。#429
   • #436–#442 MERGED 的是层叠开发分支，不是 main。MERGED ≠ 已发布。
6. 同意无人负责/停滞用确定性关联与配置周期，不为此加模型调用。
7. 50 条样本与产品验收不是我的门。 样本/标注/耗时成本接受范围由产品负责人预先确定。本 APPROVE 不把 NOT MEASURED 当成已通过。

CI 11/11 绿。文档合入是你。我不合。实现 PR 另审，且须先清上述 #423/#429 混头。

[sun-970]

Review (sun-970) — docs-only #446

不是实现批准，不是产品验收，不合入。不要 Closes #422 / #428。

核对了现网 head（2026-09-22）和 23:32 口径：

• main 已含 #421 6ea0a27。主干没有 apps/server/src/jev/，#436–#442 MERGED 的是叠层开发分支，不能当已交付。
• #423 当前 head 4e58e8e（不再是我这边上次对齐的 insertion-1 d00538f），GitHub 为 CHANGES_REQUESTED。按浩然在本 RFC 第 12 节意见，旧栈应回到 insertion-1-only，需要的话 rebase 到当前 main。本 RFC 说的 P0 从 main 单独做，不要再合旧栈。
• #429 head 59151b5，base 仍是 feat/422-jev-goal-health，CHANGES_REQUESTED；混头问题保留，Story 1 不应当 P0 基线。
• 同意三条闭环拆分：P0 处理收件箱、P1 发送前协作、P2 交付预检。确定性事实与模型建议分开；信息不足弃权；启用总开关 ≠ 批准外发任务正文。
• 现有 no-body（status/errorCode）撑不起可衡量 Jev 增量；opt-in 语义输入要另开实现 PR + 产品拍板契约。

我这边代码：按 23:32 去修 doc #83（不关 #82），Jev 旧栈不再推进合入。