Skip to content

feat(approvals,reports): 审批中心和上报中心优化 #361

Closed

Description

@waterbro-8

Source

Product owner 胡奕舟, 2026-09-18 22:32 CST (DM to 冯浩然/waterbro-8):

审批中心和上报中心优化

This issue tracks that product direction. It is not a merge/close of older D-series work.

Current baseline

  • 审批中心 (apps/desktop/renderer/src/approvals/ApprovalQueue.tsx): queue + detail drawer for pending/decided/expired capability approvals (exec/write/network/tool). Host-injected items; comment in file still notes v0 has no dedicated /approvals HTTP stream.
  • 上报中心 (apps/desktop/renderer/src/reports/ReportsCenter.tsx): read-only streams — budgets, evidence, escalations, org audits, timeline. Derived from org-audit + turn records; fail-closed empty/corrupt.

Closed historical notes (not substitutes):

Goal

Make Approval Center and Reports Center first-class operator surfaces, not leftover D4 dashboards:

  1. Approval Center: pending work is obvious, actionable, and truthful when data is missing; decided history is reviewable; grant/deny stays fail-closed.
  2. Reports Center: usage, execution results, exceptions, and org-audit facts are easier to scan, filter, and drill into related turns/approvals/goals without inventing numbers.

Non-goals

Acceptance (first cut; product owner can tighten)

  • 审批中心 empty/disconnected/pending/decided states stay distinct; never present a disconnected source as “all turns in bounds”.
  • Pending items show position, category, target, expiry; grant/deny still only via the existing resume/pendingApproval path.
  • 上报中心 overview + streams remain fact-backed; filters/search/time range do not drop fail-closed empty states.
  • Operator can jump from a report/escalation/approval row to the related turn (or get an explicit unavailable).
  • zh/en copy; light/dark; no secrets/raw prompts in list labels.
  • Renderer/shared tests for the new states; no regression of existing queue/report tests.

Related

Activity

  1. waterbro-8 commented on Sep 20, 2026

    @waterbro-8
    CollaboratorAuthor

    平台组全员派活(冯浩然 / waterbro-8)

  2. waterbro-8 commented on Sep 20, 2026

    @waterbro-8
    CollaboratorAuthor

    平台组群成员派活(冯浩然 / waterbro-8)

  3. added a commit that references this issue on Sep 20, 2026
  4. waterbro-8 commented on Sep 24, 2026

    @waterbro-8
    CollaboratorAuthor

    关单审计 HOLD(不关闭)

    @PeterGuy326 精确缺口:方向单「审批中心和上报中心优化」。#416 CLOSED 未合。#366 是持久审批中心,不是本 issue 全量 AC。无产品接受、无真人 UI。

  5. Bindy-lbb commented on Oct 8, 2026

    @Bindy-lbb
    Collaborator

    按 issue 所有人本次要求,对照完整需求与后续交付核对后关闭为 completed。此前 2026-09-24 HOLD 针对 #416 未合并及 #366 仅覆盖持久审批的旧基线;本次关闭依据是之后完成并合并的 PR #554(2026-10-05),以及其承接的已关闭 #549,而非这些旧的局部 PR。\n\n需求覆盖:审批列表/详情与元数据、既有服务端权威决策、offline/cached 只读与失效/失败状态;上报五视图的真实数据、过滤和 unknown/over-budget 语义;精确会话/turn、证据、审批及时间线定位;中英文与主题适配;相关回归测试及浏览器验收。#499/#500 已合并,提供精确 turn 回链与单次执行追溯。\n\n交付证据:#549 记录 15 组浏览器验收(640/960/1440、浅色中文/深色英文);#554 更新后记录 146/146 聚焦回归与当前 head 11/11 hosted checks,通过完整平台 gate、安全检查、staging、installer 和 layout parity。main 的 docs/design/inbox-workbench-v1.md 记录实现、契约限制和验收范围。本次为已有交付证据的核对,没有宣称新跑真实 GUI 或新增服务端权限能力。\n\n关联:#554 ,#549 ,#499 ,#500 。本次关闭不涉及 #314 / #333。

  6. Bindy-lbb commented on Oct 8, 2026

    @Bindy-lbb
    Collaborator

    更正本次清理范围:用户明确指的是自己创建的 issue,而本 issue 的创建者是 waterbro-8,Bindy-lbb 仅为 assignee。因此撤销刚才超出范围的关闭,恢复开放。此前关闭评论保留为后续交付核对参考;本次范围更正不代替该 issue 原负责人的关单决定。

  7. PeterGuy326 commented on Oct 14, 2026

    @PeterGuy326
    Contributor

    本次用户授权检查整个 RoleWeave 仓库并关闭已交付 issue。此前恢复 OPEN 是因为上一轮只清理特定创建者的 issue,属于范围修正;本轮已对完整需求重新核对。

    关闭依据为后续交付 PR #554 / issue #549 及 #499/#500:审批列表/详情、岗位/风险/时间筛选、offline/cached 只读状态、服务端权威裁决;上报五视图、真实/未知统计、过滤与精确 turn/approval/证据/时间线跳转;zh/en 与主题适配。docs/design/inbox-workbench-v1.md 和 #549 的 15 组界面验收、#554 的聚焦及跨平台检查保留了完整证据;本轮重新运行了整个本地仓库检查。

    工作区界面也实际试用了批准、拒绝、过期、只读权限和图谱/资料跳转。审批试用使用限定目录的受控协议驱动,不宣称真实模型工具审批桥接已实现。该桥接仍有独立缺口;#333 等较大的目标执行事项继续开放。按本 issue 的工作台范围关闭为 completed。

    本轮核对见 PR #601。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions