Repository navigation
fix(web): improve theme contrast and center controls across client views #211
Description
Revision r2 — ready
Shared design contract: bytefolk/design-system#29 (revision r1).
The user refined this ongoing appearance task: all clients must share the existing design language and align content by its role, rather than center all short text. Totoro (@Bindy-lbb) is the requested final reviewer.
Current acceptance (supersedes earlier alignment wording)
- AC-ALIGN: Start-align page/card/dialog headings, navigation, menus, form labels/values, filenames and prose. End-align comparable numbers and trailing metadata/actions. Center button content, compact badges/tabs and deliberate empty-state compositions. Remove blanket overrides that defeat component intent.
- AC-EMPTY: One clear empty-state title, concise explanation and an available next step; no duplicated instructions or unsupported actions. RoleWeave specifically improves the unselected local-conversation state.
- AC-THEME: Preserve previous theme/contrast fixes and consume existing shared tokens/provider/profile APIs. Follow the shared spacing, typography, radius and hierarchy contract.
- AC-VERIFY: Build and inspect light/dark, desktop/narrow, empty/populated, normal/hover/focus states. Use isolated test data. Keep reproducible evidence, independent preflight and latest-head CI separate from formal human approval.
- AC-DELIVER: Update the existing unmerged PR with scoped source, changelog and evidence. Show the final local client; request Totoro review once stable. No merge, release or installed-client replacement.
Revision history
r2: semantic alignment and coherent empty states requested by user; append-only requirement decision recorded at 2026-09-16T01:18:12.677003+00:00.
Previous revision retained for scope and evidence history
Revision r1 — ready
The user requested a complete client appearance walkthrough, successful local build, and a pull request. Some subtle/status colors have weak contrast, disabled controls fade excessively, and button/page/dialog labels align inconsistently.
Scope and acceptance criteria
- AC1: Light/dark themes provide readable foreground/background combinations for buttons, badges, inputs, disabled/loading controls, status and empty-state text.
- AC2: Control labels, page/dialog titles and short prompts are centered without changing long-form content or code alignment.
- AC3: Walk through navigation routes, populated detail views and create/edit/relation/delete/confirmation dialogs with local synthetic data. All confirmation actions retain visible localized labels.
- AC4: Typecheck, lint, unit/theme checks and web production build pass; retain text-only reproducible evidence in the PR.
- AC5: Preserve data, authorization and API behavior; no new dependencies or real account operations.
Delivery
One scoped web appearance PR, an Unreleased changelog entry, independent preflight review and current-head CI. Merge and release remain separate.
Activity
PeterGuy326 commentedon Sep 16, 2026
Revision: r2
Status: ready
Decision source: explicit user follow-up requesting one design language, semantic left/right/center alignment, better empty states, local client demonstration, published code and review by Totoro.
Shared contract: bytefolk/design-system#29 (r1).
This supersedes the blanket-centering acceptance wording in the previous revision. Keep readable theme fixes; start-align headings/navigation/forms/menus and authored text, end-align numeric comparisons and trailing actions, and center buttons/badges/empty-state compositions. Refine the same unmerged appearance PR; no merge or release is authorized.
Recorded at: 2026-09-16T01:18:12.677003+00:00
fix(web): unify shared tokens, alignment and empty states (#212)
chore: resolve CHANGELOG conflict against main (rebase #198)
waterbro-8 commentedon Sep 17, 2026
Status 2026-09-17: the appearance work is already on
main.#212 (
fix(web): unify shared tokens, alignment and empty states) merged at 2026-09-17T03:11:32Z and cites this issue (r2) plus bytefolk/design-system#29. I am not opening a second web PR.Remaining for AC-DELIVER: independent human review by @Bindy-lbb (Totoro). Merge already happened; I am not closing this issue.
waterbro-8 commentedon Sep 18, 2026
Resolved in merged PR #212 (ced64a1). The shared web tokens, semantic alignment, empty states, and contrast fixes are now on main.