Skip to content

chore(deps-dev): bump @types/node from 26.6.1 to 26.6.2 - #359

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/types/node-26.6.2
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/types/node-26.6.2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Sep 25, 2026

Copy link
Copy Markdown
Contributor

Bumps @types/node from 26.6.1 to 26.6.2.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 26.6.1 to 26.6.2.
- [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases)
- [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node)

---
updated-dependencies:
- dependency-name: "@types/node"
  dependency-version: 26.6.2
  dependency-type: direct:development
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Sep 25, 2026
@dependabot dependabot Bot added the javascript Pull requests that update javascript code label Sep 25, 2026

@waterbro-8 waterbro-8 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verdict

REQUEST_CHANGES on exact head 32a920d2defe7e95075c0730642398b363a7f91e. Not product验收. I will not merge.

@types/node 26.6.1 → 26.6.2 only. Fail-closed on CI.

Blocker

Required test (22) is FAILURE on this SHA (https://github.com/bytefolk/digital-employee/actions/runs/36089513736/job/107928661082). test (20)/(24) green does not replace Node 22. I cannot Approve a dep bump with a red required check.

I am not merging.
#359

@PeterGuy326

Copy link
Copy Markdown
Contributor

Diagnosis on the current head (after rerunning the failed jobs): the full test matrix is green — npm run check completes with # pass 2032 / # fail 0 on the rerun of the required jobs. The blocker is the final governance:check step, which fails because this PR body does not carry the repository's required governance structure (requirement trace table, validation ledger, product handoff, no-auto-close acknowledgement; see the CI error output for the full list).

Dependabot will not author that body, so this needs a maintainer decision, recorded here for the owner:

  1. Maintainer fills the governance body on this PR (the deps-only diff makes the validation ledger mostly mechanical), then merge; or
  2. Exempt dependabot-scoped PRs from the nine-section requirement in scripts/requirement-governance-check.js (a governance change that should be its own reviewed PR).

Note for #361/#362/#363 specifically: the three codeql-action bumps are interdependent — bumping only one reference leaves init and analyze on mismatched versions and CodeQL fails with Loaded a configuration file for version '4.38.0', but running version '4.38.1' (as seen on this branch). They must land together or in a single combined change.

@waterbro-8's earlier REQUEST_CHANGES cited the red test (22) check; the rerun shows that job green, so the review objection is addressed by evidence above — the remaining blocker is governance, not the dependency bump.

@dependabot @github

dependabot Bot commented on behalf of github Oct 2, 2026

Copy link
Copy Markdown
Contributor Author

Superseded by #374.

@dependabot dependabot Bot closed this Oct 2, 2026
@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/types/node-26.6.2 branch October 2, 2026 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants