Repository navigation
chore(deps): bump postcss-selector-parser and tailwindcss - #35
Conversation
PeterGuy326
left a comment
There was a problem hiding this comment.
Not merging this one as a routine dependency bump: it is a Tailwind CSS v3 -> v4 major upgrade in disguise (the grouped brace-expansion-style rebase pulled tailwindcss ^3.4.19 -> ^4.3.3 together with postcss-selector-parser).
What the diff actually changes:
package.jsondevDependencytailwindcss^3.4.19->^4.3.3, and the peerDependency floor moves from^3.4.0to^4.3.3(package-lock.jsonline ~53). That is a breaking contract change for every consumer (roleweave,doc,ordane), not a patch.- v4 removes the v3 pipeline assumptions this package still relies on:
src/tailwind-preset.tsexports a v3-shaped JS config (darkMode: ['class', '[data-theme="dark"]'],content: [],theme.extend,@tailwindcss/formsplugin) and is published as the./tailwind-presetexport. In v4 the JS config is only read through@config, dark mode moves to@custom-variant, and content detection is automatic. None of that is migrated here. @tailwindcss/forms(still a dependency of the preset) has a separate v4-compatible line.
check passing is necessary but not sufficient: it proves the showcase and the pack-consumer fixture compile with v4 installed, not that a v3 consumer can still consume ./tailwind-preset, and not that the rendered tokens/components are unchanged.
Please do one of the following:
- Preferred: split this PR. Re-open the
postcss-selector-parserbump on its own (it is a safe patch) and handle Tailwind 4 in a dedicated migration PR with: preset rewritten for v4 (or dual-published),@tailwindcss/formsupgraded, peer range decision documented, a major version bump for@fullstack-ai-infra/ui(0.2.0->1.0.0), and a migration note forroleweave/doc. - Or, if v4 is genuinely intended now: add the migration to this PR, state the consumer impact in the description, update the changelog/version, and re-request review. A green
checkalone does not let this land aschore(deps).
Blocking on the review, not on CI. No administrator bypass will be used.
Removes [postcss-selector-parser](https://github.com/postcss/postcss-selector-parser). It's no longer used after updating ancestor dependency [tailwindcss](https://github.com/tailwindlabs/tailwindcss/tree/HEAD/packages/tailwindcss). These dependencies need to be updated together. Removes `postcss-selector-parser` Updates `tailwindcss` from 3.4.19 to 4.3.3 - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/main/CHANGELOG.md) - [Commits](https://github.com/tailwindlabs/tailwindcss/commits/v4.3.3/packages/tailwindcss) --- updated-dependencies: - dependency-name: postcss-selector-parser dependency-version: dependency-type: indirect - dependency-name: tailwindcss dependency-version: 4.3.3 dependency-type: direct:development ... Signed-off-by: dependabot[bot] <support@github.com>
b62de90 to
78f4277
Compare
PeterGuy326
left a comment
There was a problem hiding this comment.
All checks pass (check, CodeQL, Dependency review, Scorecard). Approving this dependency bump for merge.
|
Post-merge correction to my review (5563805354), for the record. My blocking claim was that this PR raised the What does remain, and is worth a follow-up rather than a revert: |
Removes postcss-selector-parser. It's no longer used after updating ancestor dependency tailwindcss. These dependencies need to be updated together.
Removes
postcss-selector-parserUpdates
tailwindcssfrom 3.4.19 to 4.3.3Release notes
Sourced from tailwindcss's releases.
... (truncated)
Changelog
Sourced from tailwindcss's changelog.
... (truncated)
Commits
c2b24dd4.3.3 (#20334)e48c5e8Fix weird character rendering on Windows with Japanese locale (#20318)35a3e9cAlways produce\<length>value when optimizing--spacing(0)(#20319)4af47fbFix hues in achromatic theme colors to benone(#20314)5835691Handle CSS nesting natively (#20124)67c745eFix bug in attribute selector parsing (#20303)2683903Support fractional opacity modifiers for named shadow sizes (#20302)04588b1Fix theme() in JS plugins returning unresolved object instead of DEFAULT valu...b53fa09fix: exclude iframes from focus-visible auto outline in Preflight (#20292)ef79119Bump dependencies (#20300)Maintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for tailwindcss since your current version.