Repository navigation
Revert "Drop the timestamptz session TimeZone patch" - #4
Merged
Merged
Conversation
This restores the timestamptz session TimeZone patch. Bytebase pins the fork at the v5.12.0 rebase, which still carries the patch, so dropping it from master left the default branch and the shipped commit behaving differently -- the next upstream rebase would have branched from a master that silently lacks it. Removing the patch means choosing where timestamptz is rendered instead, which is a design question being settled separately. Until then master should match what Bytebase ships. The POSIX TimeZone failure the original commit described is real and unfixed: an instance whose session TimeZone is '+08:00' or 'EST5EDT,M3.2.0/2,M11.1.0/2' still fails every timestamptz read. That belongs to the time zone work. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the timestamptz session TimeZone patch, so master matches the commit Bytebase ships.
Bytebase pins the fork at
d3c6cdda(the v5.12.0 rebase), which still carries the patch. Dropping it from master in #3 left the default branch and the shipped commit behaving differently, so the next upstream rebase would have branched from a master that silently lacks it.With this revert, master's tree is byte-identical to
d3c6cdda:stdlib/sql.gois blob8f8940c9on both sides andgit diff d3c6cdda <revert>is empty. Both fork patches are present again —ColumnTypePrecisionScaleand the session TimeZone conversion.Removing the patch means choosing where timestamptz is rendered instead, which is a design question being settled separately in Bytebase. The POSIX
TimeZonefailure #3 described is real and still unfixed: an instance whose sessionTimeZoneis+08:00orEST5EDT,M3.2.0/2,M11.1.0/2fails every timestamptz read. That belongs with the time zone work, not with a dependency bump.🤖 Generated with Claude Code