Skip to content

feat: add org-wide Copilot code-review instruction reference set - #16

Merged
msalvatti merged 2 commits into
mainfrom
feat/copilot-org-instructions
Jul 10, 2026
Merged

feat: add org-wide Copilot code-review instruction reference set#16
msalvatti merged 2 commits into
mainfrom
feat/copilot-org-instructions

Conversation

@msalvatti

Copy link
Copy Markdown
Member

What

Adds the organization-wide Copilot code-review reference set to bymaxone/.github:

  • .github/copilot-instructions.md — stack-agnostic org baseline
  • .github/instructions/code.rust.instructions.md — Rust crates (**/*.rs)
  • .github/instructions/code.library.instructions.md@bymax-one/* libraries (src/**)
  • .github/instructions/code.app.instructions.md — consuming apps (apps/**, packages/**)
  • .github/instructions/tests.instructions.md — test suites
  • .github/agents/agent-code-reviewer.agent.md — reviewer agent definition
  • README.md — a new "Copilot code review" section

Why

Consolidates the review rules that were duplicated (and drifting) across 9 repos into one canonical, merged, stack-aware set — the universal core plus per-stack path files.

Propagation (important)

Unlike community health files, Copilot instruction files do not propagate from this repo — GitHub reads them only from the repository under review. So:

  • The universal baseline is what belongs in Org → Settings → Copilot → Custom instructions (the only layer that applies to every repo automatically).
  • These files are the canonical reference to copy into a repo and extend with its domain rules.
  • The automatic review trigger is already handled by the org ruleset copilot-code-review (~ALL).

Adds the canonical Copilot code-review baseline for the org: a stack-agnostic
copilot-instructions.md, per-stack path instructions (Rust, publishable library,
consuming app), a shared tests instruction file, and the reviewer agent
definition. Documents the set in the README.

GitHub reads Copilot instructions only from the repository under review, so these
files are a reference/starter set and do not auto-propagate. The universal
baseline is mirrored in Org > Settings > Copilot > Custom instructions, which
applies to every repository automatically.
Copilot AI review requested due to automatic review settings July 10, 2026 09:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an organization-wide, stack-aware Copilot code-review instruction “reference set” to the .github repo, intended to be copied into individual repositories (plus a README section explaining the layering and non-propagation behavior).

Changes:

  • Introduces a baseline .github/copilot-instructions.md plus per-scope instruction files under .github/instructions/.
  • Adds a reusable reviewer agent definition under .github/agents/.
  • Documents how Copilot code review is triggered and configured in README.md.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
README.md Documents the new Copilot code review layering model and links to the reference set.
.github/copilot-instructions.md Adds the universal org baseline review invariants to be mirrored into org Copilot settings / copied into repos.
.github/instructions/code.rust.instructions.md Adds Rust-specific review rules scoped to **/*.rs.
.github/instructions/code.library.instructions.md Adds library-specific review rules (notably supply-chain contract rules).
.github/instructions/code.app.instructions.md Adds app-consumer-specific review rules for apps/packages paths.
.github/instructions/tests.instructions.md Adds test-suite review rules intended to apply to common TS test filename patterns.
.github/agents/agent-code-reviewer.agent.md Adds a code reviewer agent definition and checklist/report format.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/instructions/tests.instructions.md
Comment thread .github/instructions/code.app.instructions.md
Comment thread .github/instructions/code.library.instructions.md
Widen the `applyTo` glob of code.library.instructions.md to include
`package.json` so the empty-`dependencies` supply-chain rule guides Copilot
when reviewing manifest changes, not only `src/**/*.ts`.
Copilot AI review requested due to automatic review settings July 10, 2026 09:38
@msalvatti

msalvatti commented Jul 10, 2026

Copy link
Copy Markdown
Member Author
{ "consecutiveFailures": {}, "flakyReruns": {}, "processedCommentIds": [3557794512, 3557794545, 3557794562, 3557908867, 3557908904, 3557908916], "paused": false, "terminated": true, "terminatedReason": "PR merged by developer; all Copilot threads resolved. 1 finding fixed (library applyTo->package.json in 5eb2fef); 5 dismissed as false-positive (comma-separated applyTo is the GitHub-documented multi-glob format, not a YAML list).", "lastFixCommit": "5eb2fef" }

@msalvatti
msalvatti merged commit 5fc1566 into main Jul 10, 2026
5 checks passed
@msalvatti
msalvatti deleted the feat/copilot-org-instructions branch July 10, 2026 09:40

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Comment thread .github/instructions/tests.instructions.md
Comment thread .github/instructions/code.app.instructions.md
Comment thread .github/instructions/code.library.instructions.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants