Conversation
deployYieldStrategies() and deployNFTMetadataGenerator() deploy test mocks and revert when IS_TEST and IS_TESTNET are both false, so DeployAll could not complete a mainnet run. Gate both calls on the mock modes instead: production SubConsols launch without a yield strategy and the LoanManager with a zero metadata generator, matching the live 999 stack. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
|
Contributor
Author
|
Superseded by #103 (same change; recreated with a clean commit message and description). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Found by the BW-185 deploy rehearsal on a 4663 fork:
DeployAllcannot complete a production run.deployYieldStrategies()anddeployNFTMetadataGenerator()deploy test mocks andrevertwhenIS_TESTandIS_TESTNETare both false; the 999 deploy got past this by hand-commenting the calls. This gates both calls on the mock modes insideDeployAll.run()instead, leaving the standalone scripts' reverts intact. Production SubConsols launch without a yield strategy and the LoanManager with a zero metadata generator, matching the live 999 stack.Testing
DeployAllon Robinhood mainnet (anvil fork at block 64296698) completes with this change: 260 transactions, role audit clean, positional arrays verified, all 12 Chainlink oracles reading live prices.forge test: 497 passed, 0 failed.Reviewers:
@SocksNFlops
🤖 Generated with Claude Code