ADR-0100: A pod mutator learns which app's pod it is shaping - #596
Merged
Conversation
The deploy pod-mutator seam from ADR-0061 §1 takes a bare *corev1.PodSpec and is wired once per process, so an operator can shape every app's pod or none, and cannot shape one app's differently from another's. Adds WithAppPodMutator(func(PodIdentity, *corev1.PodSpec)) alongside the existing hook, over the same stored field. WithPodMutator keeps its exact signature as a Deprecated: wrapper, so nothing breaks and ADR-0061 §3's byte-for-byte guarantee is untouched. PodIdentity carries App, Namespace and the workload role, and is constrained never to grow a field whose purpose is to be a key into an embedder's records — a seam that hands over a lookup key takes on the consumer's storage layout as part of its public API. WithPlatformPodMutator does not move: ADR-0077 §2 promises it keeps its signature, and its pods belong to no app. Lands Proposed. Signed-off-by: Nicholas Phillips <nsphilli@gmail.com>
Signed-off-by: Nicholas Phillips <nsphilli@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-0100 — a pod mutator learns which app's pod it is shaping.
It widens the deploy pod-mutator seam so a per-app policy is expressible, without changing the existing hook's signature.
Lands 🟡 Proposed. It needs a decision, not a merge — the record is the review surface.
Implemented by #595, which is open and waits on this.