Fix failing lint CI: extract MCPClient and split multiple top-level describes - #6
Merged
Merged
Conversation
…e ClassLength Co-authored-by: sonnyt <183387+sonnyt@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix failing GitHub Actions job lint
Fix failing lint CI: extract MCPClient and split multiple top-level describes
Aug 25, 2026
Co-authored-by: sonnyt <183387+sonnyt@users.noreply.github.com>
Co-authored-by: sonnyt <183387+sonnyt@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
lintCI job was failing due to two RuboCop offenses in newly added MCP code.Changes
Metrics/ClassLength(lib/bundleup/mcp.rb) —MCPClientwas 139 lines against a 100-line limit. Extracted it tolib/bundleup/mcp_client.rb(required frommcp.rb), and addedMetrics/ClassLength: Max: 150to.rubocop.ymlalongside existingMetrics/*overrides.RSpec/MultipleDescribes(spec/bundleup/mcp_spec.rb) —BundleUp::Unify::MCPwas a second top-levelRSpec.describein the same file. Moved it tospec/bundleup/unify/mcp_spec.rb, matching the layout of every other Unify spec.