Repository navigation
refactor: decouple JMAP dispatch from legacy transports - #4
Closed
lucamzanon wants to merge 1 commit into
Closed
lucamzanon wants to merge 1 commit into
lucamzanon wants to merge 1 commit into
Conversation
This was referenced Sep 11, 2026
Author
|
Superseded by #14, which consolidates this stack into one reviewable branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JMAP dispatcher currently imports and wires every legacy transport handler, so adding a Gmail API backend would require changing the protocol dispatch loop itself. This extracts those bindings into
src/backends/legacy.tsand makes the server pass an account-bound method table, request limit, and session state to the dispatcher.The legacy handler table is moved unchanged. Result and creation references, capability checks, mutation barriers, parallel read scheduling, and implicit submission responses remain in the dispatcher. Method lookup now checks own properties so inherited object members cannot be invoked as handlers.
This is the first preparatory step for the Gmail API bridge discussed in https://github.com/orgs/bulwarkmail/discussions/1007. Login, session capabilities, uploads/downloads, and IDLE still use the legacy backend. The existing Gmail provider continues using IMAP; this PR adds no Google OAuth or Gmail API connection.
Validation:
npm run buildandnpm run lintpass.mainatb73f2a7(135 passed, 3 failed): two assertions insearch.spec.tsand the error-message assertion inrefs.spec.ts.Opening as a draft for review of the backend boundary before the Gmail implementation proceeds.