Skip to content

blockchain: fix copy-paste comment on deploymentChecker.HasStarted - #2682

Closed
amalsaidov wants to merge 1 commit into
btcsuite:masterfrom
amalsaidov:blockchain-fix-hasstarted-comment
Closed

amalsaidov wants to merge 1 commit into
btcsuite:masterfrom
amalsaidov:blockchain-fix-hasstarted-comment

Conversation

@amalsaidov

Copy link
Copy Markdown

Fixes #2581.

The doc comment above deploymentChecker.HasStarted was copied from HasEnded and describes the end check rather than the start check. It reads "HasEnded returns true if the target consensus rule change has expired or timed out (at the next window)" while sitting on HasStarted.

Replace it with the wording already used by the thresholdConditionChecker interface and by bitConditionChecker.HasStarted, so it describes the start check, and keep the line noting that the value comes from the deployment's configured starter.

Comment-only change. Build and format:

go build ./blockchain/...
gofmt -l blockchain/versionbits.go

Both clean.

AI-assisted; directed, reviewed and tested by the author.

The doc comment above deploymentChecker.HasStarted was copied from
HasEnded and described the wrong method. Replace it with the wording
used by the thresholdConditionChecker interface and the
bitConditionChecker.HasStarted implementation so it describes the
start check instead of the end check.

AI-assisted; directed, reviewed and tested by the author.
@allocz

allocz commented Nov 12, 2026

Copy link
Copy Markdown
Contributor

Already handled by #2602. Please stop spamming.

@amalsaidov

Copy link
Copy Markdown
Author

You're right, #2602 already covers this and I missed it when checking for duplicates. Sorry for the noise. Closing.

@amalsaidov amalsaidov closed this Nov 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[bug]: Incorrect comments for deploymentChecker.HasStarted in blockchain/versionbits.go

2 participants