Repository navigation
blockchain: fix copy-paste comment on deploymentChecker.HasStarted - #2682
Closed
amalsaidov wants to merge 1 commit into
Closed
amalsaidov wants to merge 1 commit into
amalsaidov wants to merge 1 commit into
Conversation
The doc comment above deploymentChecker.HasStarted was copied from HasEnded and described the wrong method. Replace it with the wording used by the thresholdConditionChecker interface and the bitConditionChecker.HasStarted implementation so it describes the start check instead of the end check. AI-assisted; directed, reviewed and tested by the author.
Contributor
|
Already handled by #2602. Please stop spamming. |
Author
|
You're right, #2602 already covers this and I missed it when checking for duplicates. Sorry for the noise. Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2581.
The doc comment above
deploymentChecker.HasStartedwas copied fromHasEndedand describes the end check rather than the start check. It reads "HasEnded returns true if the target consensus rule change has expired or timed out (at the next window)" while sitting onHasStarted.Replace it with the wording already used by the
thresholdConditionCheckerinterface and bybitConditionChecker.HasStarted, so it describes the start check, and keep the line noting that the value comes from the deployment's configured starter.Comment-only change. Build and format:
Both clean.
AI-assisted; directed, reviewed and tested by the author.