Repository navigation
SignRawTransactionWithKey - #1885
galileo-pkm wants to merge 1 commit into
Conversation
Pull Request Test Coverage Report for Build 3039397202
💛 - Coveralls |
|
Can someone please review this? |
|
Thanks @galileo-pkm, I also need this function in a project. It would be great if it could be merged (as maintaining another version of this package in a fork can be tedious). I would love to take this PR ahead along with @galileo-pkm if it needs any other work. @guggero @Roasbeef |
|
@DhananjayPurohit you're welcome to review and test this PR to help move it along. @galileo-pkm I know this isn't consistently done throughout all code in |
|
I'm recovering from surgery and won't be able to work for quite some time, if anyone else wants to take over feel free to do so.
|
allocz
left a comment
There was a problem hiding this comment.
Tests passing, but needs rebase with conflict resolution. Also, why don't you add the command through the btcjson.RegisterCmd() procedure directly in the project under your control?
| // This function should only be used if a non-default signature hash type is | ||
| // desired. Otherwise, see SignRawTransactionWithKey if the RPC server already | ||
| // knows the input transactions, or SignRawTransactionWithKey2 if it does not. | ||
| func (c *Client) SignRawTransactionWithKey3(tx *wire.MsgTx, privKeysWIF []string, |
There was a problem hiding this comment.
Why not keep only this procedure as SignRawTransactionWithKey() instead of adding 3 versions of the same command?
|
Thanks for starting this, @galileo-pkm, and I hope you've recovered well. Since you offered it up for someone to take over, I've continued it in #2677. It's rebased onto master, has @allocz's review applied (one |
More or less a copy of SignRawTransactionWithWallet method that implements
the signrawtransactionwithkey bitcoind RPC.