Repository navigation
Fix scoping issue when rotating a single multipolygon member - #1038
Merged
bryceco merged 1 commit intoOct 25, 2026
Merged
Conversation
Currently, when drilling down to select a single member (way) of a multipolygon, rotating the object incorrectly rotates the entire parent relation instead of just the selected member. This PR aligns the rotation scoping with the existing translation (move) scoping. In EditorMapLayer+Edit.swift, drill-down selections set selectedWay but leave selectedRelation active. The rotateContinue method was evaluating the target as selectedRelation ?? selectedWay, which allowed the parent relation to improperly override the specific member selection. Flipping this to selectedWay ?? selectedRelation ensures the specific way selection is respected, while preserving the fallback behavior for full-relation rotations and maintaining the ability to pivot a way around a selected node. Note: I do not have a macOS/Xcode environment to compile this iOS app locally. The proposed fix in EditorMapLayer+Edit.swift reverses the selectedRelation ?? selectedWay coalescing to respect drill-down selections. Maintainer request: Please compile and verify that rotating a single multipolygon member works as intended, and that pivoting a way around a specifically selected node remains functional.
Owner
|
This looks great, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1037
Currently, when drilling down to select a single member (way) of a multipolygon, rotating the object incorrectly rotates the entire parent relation instead of just the selected member. This PR aligns the rotation scoping with the existing translation (move) scoping.
In EditorMapLayer+Edit.swift, drill-down selections set selectedWay but leave selectedRelation active. The rotateContinue method was evaluating the target as selectedRelation ?? selectedWay, which allowed the parent relation to improperly override the specific member selection. Flipping this to selectedWay ?? selectedRelation ensures the specific way selection is respected, while preserving the fallback behavior for full-relation rotations and maintaining the ability to pivot a way around a selected node.
Note: I do not have a macOS/Xcode environment to compile this iOS app locally. The proposed fix in EditorMapLayer+Edit.swift reverses the selectedRelation ?? selectedWay coalescing to respect drill-down selections.
Maintainer request: Please compile and verify that rotating a single multipolygon member works as intended, and that pivoting a way around a specifically selected node remains functional.