Repository navigation
AAP-22023: build xcui step with Go 1.27.3 (eMudhra CA compromise) - #14
Merged
Merged
Conversation
Go before 1.26.10 does not distrust the 8 compromised eMudhra intermediate keys. Raise the go directive from 1.18 to 1.26.10 so the Bitrise go toolkit (GOTOOLCHAIN=auto) compiles the step with go1.26.10. go vet's printf check is stricter at language version >= 1.24 and failed go test on non-constant format strings; pass error messages to failf via "%s". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
go 1.26.10 left stacks on Go 1.27.0-1.27.2 unpatched: they satisfy the directive so no toolchain switch happens, yet lack the eMudhra block-list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
GayatriNairAtBrowserstack
marked this pull request as ready for review
October 21, 2026 11:40
darshilgada24
approved these changes
Oct 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: https://browserstack.atlassian.net/browse/AAP-22023
What
go.mod:go 1.18->go 1.26.10.go mod tidymovedtablewriterandtestifyfrom indirect to direct requires and dropped unusedobjx. No dependency versions changed. Notoolchainline: it equals the go directive, so tidy removes it.main.go,util_fns.go: 8 callsfailf(err.Error())->failf("%s", err.Error()). At language version >= 1.24, thego vetprintf check flags non-constant format strings, andgo testruns vet, so tests failed without this. Behaviour is unchanged, except that a%inside an error message is no longer misformatted.Why
Go releases before 1.26.10 / 1.27.3 do not distrust the 8 compromised eMudhra intermediate keys. This step sends BrowserStack credentials to
api-cloud.browserstack.comfrom customer CI. In go1.26.10,crypto/x509hasdistrustedSPKIHashes(8 entries). BothVerify(verify.go) and the macOS platform-verifier path (root_darwin.go) enforce it. Local go1.26.4 does not have it.How it reaches customers
The Bitrise go toolkit (
toolkit: goin step.yml, stepman v0.27.0 as vendored in bitrise CLI master) works like this:goon PATH if it is >= 1.22.12. Otherwise it installs go1.22.12.go build -o <bin>withGO111MODULE=on. It does not setGOTOOLCHAIN, so the defaultautoapplies.go 1.26.10in go.mod, the stack Go (>= 1.21) downloads and uses go1.26.10. No step.yml change is needed, and step.yml has no Go version field (GoStepToolkitModelhas onlypackage_name).GOTOOLCHAIN=local, or blocks thegolang.org/toolchainmodule download, the build fails withgo.mod requires go >= 1.26.10. It does not fall back to an older Go.Verification (local, darwin/arm64)
go version: go1.26.4 (local).GOTOOLCHAIN=go1.26.10 go version: go1.26.10.go mod tidy: rc=0go build ./...: rc=0go vet ./...: rc=0 (before the failf fix: 8non-constant format string in call to ...failf, at main.go:38,48,54,66,72,82,102 and util_fns.go:127)go test ./...:ok github.com/browserstack/browserstack-bitrise-xcui-step 3.533sgo version -mon the binary:go1.26.10GOTOOLCHAIN=local go build ./...with go1.26.4:go: go.mod requires go >= 1.26.10 (running go 1.26.4; GOTOOLCHAIN=local)Notes:
io/ioutil(deprecated, still works) is left unchanged to keep this diff minimal.Release steps still needed
1.0.1). BumpBITRISE_STEP_VERSIONin bitrise.yml as needed.bitrise run share-this-stepand open the bitrise-steplib PR.🤖 Generated with Claude Code