Add connector test coverage: Reddit, YouTube, Letterboxd (63 tests) - #32
Open
brooksRoley wants to merge 1 commit into
Open
Add connector test coverage: Reddit, YouTube, Letterboxd (63 tests)#32brooksRoley wants to merge 1 commit into
brooksRoley wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extends backend connector test coverage — "welcome work" per the ChannelZero routine. Three previously-untested connectors now have suites following the established
FakeConn/test_github_connector.py/test_spotify_connector.pypattern (hermetic — no real DB or network; httpx and LLM fully mocked).What's added
server/tests/test_reddit_connector.pyserver/tests/test_youtube_connector.pyserver/tests/test_letterboxd_connector.pyEach suite covers: the pure
_distill_profilefunction (shape, aggregation, caps, defaults),/profile(null vs JSON-string vs dict passthrough),/analyze(404 guards + mocked-LLM narrative), and the/connect503-not-configured guard. Letterboxd additionally covers its/ingestflow (search→entries→watchlist, correctstore_provider_datacall, 404 on unknown username).Verification
Notes from the agents
/connectcorrectly gates ongoogle_client_id(shared Google OAuth app), not a youtube-specific id — the test asserts this.🤖 Generated with Claude Code