Repository navigation
Conversation
Optional NULL-terminated domain list in bacaro_new() lets peers skip DEALER creation and snapshot requests when subscriptions don't overlap with the publisher's declared domains. Backwards compatible: passing nullptr preserves existing behaviour.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bacaro_newgains an optional second argument: a NULL-terminated array of domain strings the process publishes (e.g.{"sensors", "power", nullptr}).manifestfile is written alongside.puband.rep; it is cleaned up onbacaro_destroyPeerInfonullptrpreserves existing behaviour exactlyWhy
On a device with many processes, every subscriber used to send snapshot requests to every peer at discovery, even when there was no domain overlap. The manifest lets processes declare what they publish at startup so peers can skip those handshakes entirely.
Test plan
ctest)nullptr) behaves as beforemanifest_overlapsunit tests cover exact match, child, parent, empty prefix, and no-overlap cases