Abc to booklet errors#56
Merged
Merged
Conversation
chrisglein
commented
Jul 6, 2026
chrisglein
left a comment
Collaborator
Author
There was a problem hiding this comment.
Manual edits to what the robots did
Co-authored-by: Chris Glein <26607885+chrisglein@users.noreply.github.com>
Also emphasize the caller/chorus roles with italics
Collaborator
Author
- Tighten chorus boxes - More clearly label QR code - Chorus refrains don't indent
chrisglein
commented
Jul 6, 2026
Comment on lines
-3
to
-13
| [Eb/I]Who's the king of the [Ab/IV]fighting [Eb/I]Dutch | ||
| > [Eb/I]Skipper [Bb/V]Jan Rebec | ||
| [Eb/I]And who do the sailors [Ab/IV]fear so much | ||
| > [Eb/I]Skipper [Bb/V]Jan [Eb/I]Rebec | ||
| [Eb]Who's the king of the [Ab]fighting [Eb]Dutch | ||
| > [Eb]Skipper [Bb]Jan Rebec | ||
| [Eb]And who do the sailors [Ab]fear so much | ||
| > [Eb]Skipper [Bb]Jan [Eb]Rebec | ||
|
|
||
| {chorus} | ||
| > And it's | ||
| > [Eb/I]Ja ja leave your hammocks | ||
| > [Eb/I]Ja ja [Bb/V] *hands on deck* | ||
| > [Eb/I]Ja ja [Ab/IV] break your backs for | ||
| > [Eb/I]Skipper [Bb/V]Jan [Eb/I]Rebec |
Collaborator
Author
There was a problem hiding this comment.
I think if we do this, we do it proper. Across all songs. With some tight graphic design of color/iconography. Doing it for one song is weird.
Owner
brewingcode
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Before going over my manual edits, I tried scolding the robots to check their work and fix it first.
Prompts:
1
2
3
4
Next step: Review my manual notes and compare to the edits here. See how well the clankers did.
Correct booklet chord transcriptions against ABC sources
Summary
Audited all 16 songs in
booklet/against theirsongs/*.txtABC sources andfixed the chord errors, treating the ABC as the source of truth. 11 of 16
songs had issues; all are now corrected and the booklet HTML rebuilt. Also
adds a reusable skill documenting the ABC↔booklet workflow and ignores the
editor/tool scratch directories.
Full per-song reasoning (chord-by-chord alignment) is in
SongAnalysis.md.What the audit found
vocabulary — the booklet usually picks the right chords but hangs them on the
wrong word.
songs. A chord change gets parked on a stressed/final word instead of the
syllable whose melody note the ABC attaches it to. Frequent side effect:
losing an internal return (e.g.
C → F → Ccollapses toC … F).Roll the Old Chariot Along, Wellerman, South Australia, Joli Rouge, Randy Dandy O.
aligned to the ABC's
"chord"-before-note positions. (Unchorded verses andtonic-on-pickup are house style, not errors.)
Changes
Wrong-chord fixes
[C]hang→And we'll [F]all hang [A7]on be[Dm]hind— restores the V7→i cadence toDmFmmoved off "Billy" ontothe [Fm]name of the ship was the [Cm]Billy o Tea; chorusCmmoved from "rum" to[Cm]tea[A]on "Australia";B7moved to'round(verse) and ontoAus[B7]tral[E]iain both refrainsLate / misaligned-placement fixes
F → Creturns in chorus L1 & L3Fmoved to "we're" / "farewell"[C]way [G]hey [D]bullyand[G]shin[D7]bone [G]al[F]Early [C]in the [Dm]morning![F]voyage [C]is long [G]and the winds [C]don't blowGmoved to "ho";Dmoved to "head"ABC-faithful rebuilds
(
Dm–Am–Dm–Am,Dm–C–Dm–C,Dm–C–F–C,Dm–F–C).a true minor-third transposition of the ABC:
Cm–Bb–Eb–G7, restoring the minortonic at the phrase openings and the previously-dropped
G7dominant.Tooling, docs & hygiene
SongAnalysis.md— the full audit (per-song verdicts, error taxonomy, high-level analysis)..github/skills/booklet-song-from-abc/— new skill capturing both formats, thenote→syllable→chord alignment procedure, and the common pitfalls, for future
generation/fix work.
.gitignore— ignore/.playwright-mcp/and/.temp/scratch; removed thestray
.playwright-mcp/snapshot files from the working tree.booklet/sea-shanties.html— regenerated vianpm run booklet.Unchanged (verified clean)
Barrett's Privateers, Health to the Company, Old Maui, Skipper Jan Rebec,
Whiskey Johnny. (Skipper Jan Rebec's ABC has no lyric lines, so only chord
vocabulary/cadences could be verified.)
How it was verified
w:syllables →"chord"positions.npm run bookletrebuilds cleanly (34 logical pages / 9 sheets, no errors).booklet/sea-shanties.html(e.g. theA7cadence, Randy Dandy's
Cm…G7, Joli Rouge's chorus).Notes
booklet/cover.htmlcarries a pre-existing, unrelated change (adds<link rel="stylesheet" href="shanties.css">) that predates this work — drop itfrom the PR if it wasn't meant to ship here.
ABC, but you may want to confirm against the band's official chart.
booklet/sea-shanties.html/sea-shanties-single.htmlarecommitted build output. Reasonable if treated as the shareable deliverable;
happy to gitignore +
git rm --cachedthem instead if preferred.