web usage metadata validation - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces new functionality for unauthenticated Last.fm catalog lookups, improves Last.fm API request encoding, and updates the MediaRemoteAdapter dependency. It also refactors parts of the codebase for consistency and maintainability.
New Last.fm Catalog Lookup Functionality:
LastFmCatalogClient.swiftfor unauthenticated Last.fm catalog lookups, allowing metadata validation without requiring user authentication. This is integrated into the project and build system. [1] [2] [3] [4] [5]Last.fm API Improvements:
LastFmRequestEncodingfor proper RFC 3986-compliant query encoding, fixing issues with special characters in Last.fm API requests.LastFmManagerDesktop.swiftto use the new encoding utility for both GET and POST requests, and refactored error handling to use a unifiedErrorResponsetype. [1] [2] [3]Dependency Updates:
mediaremote-adapterdependency to a new (forked) repository and pinned it to a specific revision for improved reliability. [1] [2]Build System and Project Configuration:
LastFmCatalogClient.swift,TrackMetadataResolver.swift, and their tests) in the Xcode project. [1] [2] [3] [4] [5] [6] [7] [8]Codebase Cleanup:
NowPlayingFetcher.swiftto simplify music app identification logic.How to test
Author checklist
This PR: