Skip to content

web usage metadata validation - #14

Merged
bretth18 merged 8 commits into
mainfrom
b/web-usage-metadata-checks
Jul 27, 2026
Merged

web usage metadata validation#14
bretth18 merged 8 commits into
mainfrom
b/web-usage-metadata-checks

Conversation

@bretth18

@bretth18 bretth18 commented Jul 27, 2026

Copy link
Copy Markdown
Owner

Description

This PR introduces new functionality for unauthenticated Last.fm catalog lookups, improves Last.fm API request encoding, and updates the MediaRemoteAdapter dependency. It also refactors parts of the codebase for consistency and maintainability.

New Last.fm Catalog Lookup Functionality:

  • Added LastFmCatalogClient.swift for unauthenticated Last.fm catalog lookups, allowing metadata validation without requiring user authentication. This is integrated into the project and build system. [1] [2] [3] [4] [5]

Last.fm API Improvements:

  • Introduced LastFmRequestEncoding for proper RFC 3986-compliant query encoding, fixing issues with special characters in Last.fm API requests.
  • Updated LastFmManagerDesktop.swift to use the new encoding utility for both GET and POST requests, and refactored error handling to use a unified ErrorResponse type. [1] [2] [3]

Dependency Updates:

  • Switched the mediaremote-adapter dependency to a new (forked) repository and pinned it to a specific revision for improved reliability. [1] [2]

Build System and Project Configuration:

  • Registered new source and test files (LastFmCatalogClient.swift, TrackMetadataResolver.swift, and their tests) in the Xcode project. [1] [2] [3] [4] [5] [6] [7] [8]
  • Bumped the project version from 11 to 12. [1] [2]

Codebase Cleanup:

  • Removed unused or redundant code in NowPlayingFetcher.swift to simplify music app identification logic.

How to test

  • Ensure all checks pass

Author checklist

This PR:

  • Satisfies a goal that is specific & clearly motivated
  • Adds value in isolation (whether user-facing or sustainability-related)
  • Contains a concise & easy-to-understand title + description
  • Adheres to SRP by default
  • Presents the best possible implementation to meet its goal, given constraints at hand

@bretth18 bretth18 self-assigned this Jul 27, 2026
@bretth18
bretth18 marked this pull request as ready for review July 27, 2026 22:11
@bretth18
bretth18 merged commit 1bc30af into main Jul 27, 2026
2 checks passed
@bretth18
bretth18 deleted the b/web-usage-metadata-checks branch July 27, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant