refactor services and improve logging and friends display - #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR makes several significant changes to the project structure and the Friends filtering feature. The most impactful updates are the removal of the unused Custom Scrobbler (Bluesky) service, the introduction of a grouped Services folder in the Xcode project, and the implementation of a more flexible and efficient Friends filter. Additionally, some legacy or unused code and preferences have been cleaned up for maintainability.
Project structure and service cleanup:
CustomScrobblingService.swiftandBlueskyOAuthManager.swiftfrom the project, including source files, build phases, and file groups, reflecting the discontinuation of the Bluesky/Custom Scrobbler integration. [1] [2] [3] [4] [5]Servicesgroup in the Xcode project to organize related service files such asScrobbler.swift,ScrobblingService.swift,LastFmManager.swift,LastFmManagerDesktop.swift, andNowPlayingFetcher.swift. [1] [2]Friends filter improvements:
allFriendsproperty to back the filter picker, allowing for efficient filtering and display updates without additional network requests. [1] [2]Preferences and legacy code cleanup:
UserDefaultsduring initialization. [1] [2]selectedFriendsproperty inPreferencesManagerto persist the user's filter selection for friends.Other codebase improvements:
passwordproperty from bothPreferencesManagerandLastFmDesktopManager, simplifying their interfaces and constructors. [1] [2] [3]These changes improve the maintainability of the codebase, streamline the project structure, and enhance the user experience when filtering friends.
How to test
Author checklist
This PR: