Update sync to have --force instead of --fresh and include the input path in the idempotency key#272
Merged
Merged
Conversation
Contributor
|
Latest downloadable build artifacts for this PR commit
Available artifact names
|
Abhijeet Prasad (AbhiPrasad)
approved these changes
Jul 15, 2026
Contributor
|
I think there are some other issues introduced give me a sec |
Contributor
|
Adding input_path to the spec makes the hash different, which means customers who have already pushed a dataset, update bt then push the dataset again will push the entire dataset again even if it's unchanged. Maybe not worth adding code for compatibility but I'd like a confirmation it's ok. |
Cedric / ViaDézo1er (viadezo1er)
approved these changes
Jul 15, 2026
Contributor
|
The bug I found existed before this pr, so it doesn't block it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bt sync pushwould sometimes say "i already sync'd this", but it hadn't.