Skip to content

fix(cohere): drop redundant _try_to_dict pass in tool-call iteration #586

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhijeet Prasad (AbhiPrasad) merged 1 commit into from
Jul 17, 2026
Merged

fix(cohere): drop redundant _try_to_dict pass in tool-call iteration #586

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions py/src/braintrust/integrations/cohere/tracing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -632,10 +632,7 @@ def _tool_call_metadata(tool_call: Any) -> dict[str, Any] | None:
def _iter_tool_calls(output: Any):
if output is None:
return
output_dict = output if isinstance(output, dict) else _try_to_dict(output)
if not isinstance(output_dict, dict):
return
tool_calls = output_dict.get("tool_calls")
tool_calls = _get_field(output, "tool_calls")
if not isinstance(tool_calls, list):
return
for tool_call in tool_calls:
Expand Down