Skip to content

fix(adk): fix llm span metadata (provider, tools, errors) #580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Abhijeet Prasad (AbhiPrasad) merged 11 commits into from
Jul 16, 2026
Merged

fix(adk): fix llm span metadata (provider, tools, errors) #580

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b0b9c4e
fix(adk): align integration with sdk-integrations SKILL
starfolkbot Jul 16, 2026
00013d6
chore(adk): drop test_adk_mcp_tool.py
starfolkbot Jul 16, 2026
f197cf9
refactor(adk): make _capture_config a strict allowlist; drop deep-cop…
starfolkbot Jul 16, 2026
5378dff
chore(adk): drop explanatory comments in test assertions
starfolkbot Jul 16, 2026
224a476
chore(adk): trim _capture_config docstring
starfolkbot Jul 16, 2026
9e752f6
refactor(adk): drop _get_field, use plain getattr
starfolkbot Jul 16, 2026
3bc65a4
test(adk): drop fake-fixture unit tests, lean on VCR coverage
starfolkbot Jul 16, 2026
5cda5fb
test(adk): drop remaining fake-LLM and non-ADK unit tests
starfolkbot Jul 16, 2026
7c2c14c
style(adk): apply ruff format
starfolkbot Jul 16, 2026
b9ff136
ci: retrigger checks
starfolkbot Jul 16, 2026
6ace474
fix(ci): pin opentelemetry-api<1.40 for pydantic-ai 0.1.9
starfolkbot Jul 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion py/noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -442,6 +442,11 @@ def test_pydantic_ai_wrap_openai(session, version):
"""Test pydantic_ai with wrap_openai() approach - supports older versions."""
_install_test_deps(session)
_install_matrix_dep(session, "pydantic-ai-wrap-openai", version)
# pydantic-ai 0.1.9 unconditionally imports ``from opentelemetry._events import Event``.
# The ``_events`` module was removed from ``opentelemetry-api`` in 1.40+, so a fresh
# resolution on newer opentelemetry releases picks a version that breaks import.
if version == "0.1.9":
session.install("opentelemetry-api<1.40", silent=SILENT_INSTALLS)
_run_tests(session, f"{INTEGRATION_DIR}/pydantic_ai/test_pydantic_ai_wrap_openai.py", version=version)


Expand Down Expand Up @@ -513,7 +518,6 @@ def test_google_adk(session, version):
_install_test_deps(session)
_install_matrix_dep(session, "google-adk", version)
_run_tests(session, f"{INTEGRATION_DIR}/adk/test_adk.py", version=version)
_run_tests(session, f"{INTEGRATION_DIR}/adk/test_adk_mcp_tool.py", version=version)


LANGCHAIN_VERSIONS = _get_matrix_versions("langchain-core")
Expand Down
254 changes: 0 additions & 254 deletions ...braintrust/integrations/adk/cassettes/1.14.1/test_adk_agent_metadata_with_attachment.yaml
View file
Open in desktop

This file was deleted.

Loading