Skip to content

fix(settings): un ?tab= inválido cae en la primera pestaña disponible - #8

Merged
bpstack merged 2 commits into
claude/compassionate-planck-gh6aoffrom
opencode/settings-tab
Oct 12, 2026
Merged

bpstack merged 2 commits into
claude/compassionate-planck-gh6aoffrom
opencode/settings-tab

Conversation

@bpstack

@bpstack bpstack commented Oct 12, 2026

Copy link
Copy Markdown
Owner

Cambios

  • Configuración: si ?tab= no existe o es de una pestaña sin permiso, se abre la primera disponible en vez de dejar el contenido en blanco.
  • docs/TODO.md: se borra el punto, ya resuelto.

Por qué

Con un ?tab= inválido (p. ej. recepción con ?tab=users) la página quedaba en blanco.

- Add resolveSettingsTab helper to validate tab parameter

- Use helper in SettingsPanel to handle invalid ?tab= values

- Add 5 test cases for the helper
- Remove the "?tab= of a tab without permission" entry.

Why: resolveSettingsTab falls back to the first available tab. Checked in
the browser: admin with ?tab=xxx and ?tab=demo opens Users, a receptionist
with ?tab=users opens Notifications.
@vercel

vercel Bot commented Oct 12, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
four-points Building Building Preview Oct 12, 2026 7:42am UTC

@bpstack
bpstack merged commit cc45039 into claude/compassionate-planck-gh6aof Oct 12, 2026
5 of 6 checks passed
@bpstack
bpstack deleted the opencode/settings-tab branch October 12, 2026 19:02

This branch was successfully deployed

1 active deployment
Preview — 286cb5c9 Deployed Oct 12, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant