Repository navigation
fix(groups): la ficha se actualiza al editar y mantenimiento no ve contactos - #18
Merged
bpstack merged 2 commits intoOct 12, 2026
Merged
Conversation
…rom maintenance - GroupDetailClient: the page paints useGroupStore, filled once from the server; it now copies the fresh useGroup data into the store and, after an edit, invalidates the group key (payments, status and rooms share the prefix). useGroup reads initialGroup.id, not the store, which may still hold the previous page's group. - canViewGroupContacts (admin, recepcionista, group-admin) guards GET /contacts and /contacts/primary; the history leaves out the group_contacts entries, which keep the email and phone as JSON, for the other roles. - Frontend: the contacts tab and its query are left out for those roles, ?tab=contacts opens the summary, and ContactPanel drops a contacts query it never read. - docs/groups: who sees the contacts. - Tests: the middleware, the routes and the history filter; the page code (no frontend test runner). Why: after "Grupo actualizado correctamente" the page kept the old total and balance until another action reloaded it; and every role, maintenance included, could read the contacts. Decided on 2026-10-12: maintenance keeps groups for its notifications, not the contacts. Checked in the browser: before, a 3200 -> 4000 edit kept showing 3200; now it shows 4000 at once; as maintenance there is no contacts tab, no /contacts request and no contact entry in the history; admin still sees both.
- The 48-hour duplicate check: a payment due soon gets the 15- and 7-day reminders every two days, overdue payments and rooming lists repeat too. Why: the doc said a reminder is never created twice; the owner decided on 2026-10-12 to keep the current behaviour.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cambios
mantenimientodesaparecen la pestaña y la petición.docs/groups: quién ve los contactos y cómo se repiten de verdad los recordatorios.Por qué
Editar el importe no se veía hasta recargar, y
mantenimientoveía correos y teléfonos de los contactos. Decidido el 2026-10-12.