Fix nvidia fallback services failing to start

[vigh-m]

Issue number:

Closes #464

Description of changes:

• Add the %build sections to kmod-nvidia specfiles
• Fix type in DevID for g4dn instances causing the open driver to be loaded instead of the tesla driver. With this change, we are in-line with what the EKS optimized AMI does
• Change the dependency of the open-gpu-license-fallback.service and the tesla-license-fallback.service to depend on the nvidia-gridd.service which itself depends on preconfigured.target ensuring all are started on all variants.

Testing done:

• Build and test the a combination of ecs and k8s variants on the 6.1, 6.12, and 6.18 kernels with the 580 driver

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

[ginglis13]

LGTM - nit on missing space after : in commit message kmod-nvidia:fallback.service to install on all variants

[arnaldo2792]

Two nits:

• I would have kept this commit out of the series, because you are fixing three different problems
• You could have used kmod-nvidia- in the commit message

[arnaldo2792]

In your PR description, can you add the testing you did here to validate that g4dn.* are using the correct driver. And add in the commit message that we are following the steps of the EKS Optimized AMI.

[arnaldo2792]

The commit message is not well formatted and confusing. Could you please expand on how your change fixes the problem with non-k8s variants?

Also, should the service run After=nvidia-gridd.service? WantedBy doesn't guarantee ordering.

[arnaldo2792]

In the commit message, or even in this file, explain that this unit doesn't need an Install section because the service will be started by a timer.

But also, you must guarantee that the service will start as soon as we reach multi-user.target. If you validated this, call it out in the PR description. And in the commit message, call out why the wanted ordering is preserved (e.g. timers.target run before, in parallel, after multi-user.target whichever is the case we want).