Third party dev/lib package updates#972
Conversation
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
| Str_Snprintf(cmsg, sizeof(cmsg), "%s: %s command \"%s\"", | ||
| __func__, reboot ? "reboot" : "shutdown", cmd); | ||
|
|
||
| - if (status == -1) { |
There was a problem hiding this comment.
why are we leaving this condition out?
There was a problem hiding this comment.
We actually catch our status with if (!success), making this one redundant.
| --enable-editline=no \ | ||
| --enable-scrub=no | ||
| --enable-scrub=no \ | ||
| --enable-healer=no |
There was a problem hiding this comment.
was this the default option earlier?
There was a problem hiding this comment.
There wasn't one. xfs_healer is a new binary and I believe it requires kernel 7.0+ to function properly.
| Name: %{_cross_os}bash | ||
| Version: 5.3 | ||
| Release: 1%{?dist} | ||
| Release: 2%{?dist} |
There was a problem hiding this comment.
Why are we increasing the release version?
There was a problem hiding this comment.
It feels strange to add patches without changing the versioning at all. I'd actually prefer we do 15 and just going forward we bump the release to match the patches.
| + fprintf(stderr, "Command %s failed with exit %d\n", cmd, exit_status); | ||
| + Warning("%s: %s command \"%s\": failed to execute\n", | ||
| + __func__, reboot ? "reboot" : "shutdown", cmd); | ||
| + return -1; |
There was a problem hiding this comment.
Why did we add a return -1; here?
There was a problem hiding this comment.
Returning -1 ensures the caller's fallback path (SystemUninhibitedShutdown) triggers when the command couldn't execute, matching the != 0 check upstream already uses.
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
Signed-off-by: Patrick J.P. Culp <jpculp@amazon.com>
jpculp
force-pushed
the
20260629-bump-dev-pkgs
branch
from
3d46bc9 to
7fc1bd0
Compare
|
Adjusted how we do versioning in |
3 participants
Description of changes:
coreutilsto v9.11ethtoolto v7.0iprouteto v7.1.0makedumpfileto v1.7.9straceto v7.1bashto v5.3.15xfsprogsto v7.0.1util-linuxto v2.42.2open-vm-toolsto v13.1.0libglibto v2.88.2Testing done:
sha256sumethtoolip addrecho 'c' > /proc/sysrq-triggerstrace lsmkfs.xfslsblkandfindmntgovcTerms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.