feat: k8s: gate kubelet --container-runtime-endpoint on setting#968
Draft
shvbsle wants to merge 1 commit into
Draft
feat: k8s: gate kubelet --container-runtime-endpoint on setting#968shvbsle wants to merge 1 commit into
shvbsle wants to merge 1 commit into
Conversation
Wrap the `--container-runtime-endpoint` kubelet CLI flag in each kubelet-exec-start-conf template on `settings.kubernetes.container-runtime-endpoint`, falling back to the current `unix:///run/containerd/containerd.sock` default when unset. Signed-off-by: Shiv Bhosale <shvbsle@amazon.com>
ginglis13
reviewed
Jul 8, 2026
Comment on lines
+18
to
+22
| {{#if settings.kubernetes.container-runtime-endpoint}} | ||
| --container-runtime-endpoint={{settings.kubernetes.container-runtime-endpoint}} \ | ||
| {{else}} | ||
| --container-runtime-endpoint=unix:///run/containerd/containerd.sock \ | ||
| {{/if}} |
Contributor
There was a problem hiding this comment.
Suggested change
| {{#if settings.kubernetes.container-runtime-endpoint}} | |
| --container-runtime-endpoint={{settings.kubernetes.container-runtime-endpoint}} \ | |
| {{else}} | |
| --container-runtime-endpoint=unix:///run/containerd/containerd.sock \ | |
| {{/if}} | |
| --container-runtime-endpoint={{default "unix:///run/containerd/containerd.sock" settings.kubernetes.container-runtime-endpoint}} \ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Wrap the
--container-runtime-endpointkubelet CLI flag in each kubelet-exec-start-conf template onsettings.kubernetes.container-runtime-endpoint, falling back to the currentunix:///run/containerd/containerd.sockdefault when unset.Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.