Add create-device subcommand to ghostdog#963
Merged
Merged
Conversation
Some out-of-tree kernel modules (e.g. those with licensing restrictions) do not create their own device nodes. Add a create-device subcommand to ghostdog to provide a helper for creating device nodes on behalf of such modules. Signed-off-by: Arnaldo Garcia Rincon <agarrcia@amazon.com>
piyush-jena
reviewed
Jul 2, 2026
ginglis13
approved these changes
Jul 2, 2026
| } | ||
|
|
||
| /// Look up a device name in the parsed /proc/devices and return (major, type) | ||
| fn lookup_device(devices: &ProcDevices, name: &str) -> Result<(u32, DeviceType)> { |
Contributor
There was a problem hiding this comment.
why not impl on ProcDevices ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Some out-of-tree kernel modules (e.g. those with licensing restrictions) do not create their own device nodes. Add a create-device subcommand to ghostdog to provide a helper for creating device nodes on behalf of such modules.
Testing done:
In combination with bottlerocket-os/bottlerocket-kernel-kit#462, I confirmed that the device
/dev/gdrdrvwas created after the kernel module was loaded:Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.