feat: add hugepages support#952
Draft
piyush-jena wants to merge 2 commits into
Draft
Conversation
piyush-jena
force-pushed
the
hugepages-final
branch
9 times, most recently
from
2c7149a to
b784d20
Compare
piyush-jena
force-pushed
the
hugepages-final
branch
from
b784d20 to
56212b2
Compare
Signed-off-by: Piyush Jena <jepiyush@amazon.com>
piyush-jena
force-pushed
the
hugepages-final
branch
from
56212b2 to
5aed87c
Compare
ginglis13
reviewed
Jul 8, 2026
Comment on lines
+134
to
+140
| ensure!( | ||
| dir.exists(), | ||
| error::UnsupportedHugepageSizeSnafu { | ||
| size_kib: page_size, | ||
| } | ||
| ); | ||
|
|
Contributor
There was a problem hiding this comment.
This error could also be that the requested numa node doesn't exist. Can you distinguish between the two, or add the numa node info to this snafu report?
ginglis13
reviewed
Jul 8, 2026
ginglis13
left a comment
ginglis13
left a comment
Contributor
There was a problem hiding this comment.
Please also update the corndog README to reflect these changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.