Repository navigation
Conversation
This was referenced Oct 19, 2026
Open
Open
gouveags
marked this pull request as ready for review
October 19, 2026 00:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: #3833.
Accept
request_min_compression_size_bytesfrom 0 through 10485760, matching the shared AWS SDK configuration range requested in the issue discussion. The validator currently rejects zero and values above 1 MiB.A zero threshold lets existing automatic gzip compression handle eligible buffered requests regardless of size. Operations without compression metadata still send uncompressed requests. The default threshold, disable setting, codec selection, signing and retry behavior are unchanged. This does not enable compression on Bedrock or Mantle; service acceptance and upstream metadata remain separate work.
The implementation changes the two bounds in the shared client/config-store validator. Tests cover both inclusive endpoints, formerly rejected values inside the new range, out-of-range rejection, and a zero-threshold small request with and without operation support.
Verification
Hosted CI on the final head reports
action_requiredwith no jobs run. Maintainer action is needed before hosted CI can validate this revision.Reviewed implementation:
a3e32d588458972d2dd11bccdf7ea24ff37c0a00.git diff --checkpassed.Tests ran on Python 3.12.14. They are hermetic; no live AWS requests or latency claims. The full repository suite, supported-Python matrix and Sphinx build were not run. Platform E2E changes are not needed: focused client/config and HTTP-stub tests cover the changed contract.
Related work: Smithy runtime/code generation and new SDK adoption. Neither is a dependency of this botocore fix.
Generated with AI assistance. Scope reviewed and requested by Gabriel Gouvea; final code remains subject to maintainer review.