Repository navigation
Conversation
borco/scintilla-py#4 shipped in 5.6.3.6 (manylinux_2_38_aarch64 wheel), unblocking the CI job disabled for lacking one -- `uv sync`'s dev-group pyside6-scintilla dependency no longer needs to build from sdist (which failed for lacking a Qt6 SDK on the arm runner). The cibuildwheel test-skip for manylinux_aarch64 wheels is lifted for the same reason.
Mirrors pyside6-scintilla's move to a single abi3 wheel per platform (its issue #13), but nanobind's STABLE_ABI mode hard-requires CPython >=3.12 (unlike shiboken6's FORCE_LIMITED_API, which can float the stable-ABI down to 3.11) -- so a single wheel covering 3.11+ isn't possible here. Ships a version-specific cp311 wheel plus a cp312-abi3 wheel (forward-compatible with 3.13, 3.14, etc. without a rebuild) per platform instead, keeping the 3.11 floor while still cutting the wheel count in half. Verified locally: built once against Python 3.12 and loaded that same binary, unmodified, under 3.13 and 3.14.
The lockfile was still pinned to 5.6.3.3, which predates the aarch64 wheel -- `uv sync` on the just-reenabled ubuntu-24.04-arm CI job fell back to building it from sdist and failed for lacking a Qt6 SDK, the same failure the aarch64 job was originally disabled for.
Owner
Author
|
Closing — merging locally with --no-ff instead, per this repo's usual workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ubuntu-24.04-armCI job that was disabled for lacking one -- re-enabled it and dropped the now-unneeded cibuildwheeltest-skipfor manylinux_aarch64 wheels.STABLE_ABImode hard-requires CPython >=3.12 (unlike shiboken6'sFORCE_LIMITED_API, which floats down to 3.11) -- so a single wheel covering 3.11+ isn't possible here. Ships a version-specificcp311wheel plus acp312-abi3wheel (forward-compatible with 3.13, 3.14, etc. without a rebuild) per platform instead: 10 wheels per release instead of 20, while keeping the 3.11 floor.Test plan
uv run pytestpasses locally (cp312 stable-ABI build)uv run ruff check ./ruff format --check ./check_docs_sync.py/pyrightall pass_lexilla.pyd, unmodified, under 3.13 and 3.14 -- confirms true forward compatibility of the abi3 build