Repository navigation
Conversation
Vega does not rewind HTMLMediaElement.loop, so the silent keep-awake file ended the audio-playback session after 300 seconds and LCM could background the wall with no crash report. Seek back to the start on ended, and set a permanent lifespan with a one-year inactivity timeout. Refs #22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Refs #22.
On a Fire TV Stick HD the release build stopped about 33 minutes after launch, with no crash report, after memory had already settled near 300 MiB. Nothing in the app waits that long, the photo pool is capped, and a dropped WebSocket reconnects instead of exiting. A silent stop matches Vega's lifecycle manager: an inactive foreground component is sent to the background when
timeout-secsfires, and a display forced off kills the process. The only thing that holds the display is anaudio-playbacksession.That session was not held.
HTMLMediaElement.loopis unsupported, and@amazon-devices/react-native-w3cmedia2.3.4 callsplay()onendedwithout seeking to 0 and swallows the event. The silent file is 300 seconds, so the session can end about five minutes after the player starts. The ~33 minute figure is one measurement, not a documented constant (published idle defaults are a 5-minute screensaver and low-power mode at 15 minutes). Once the audio session dies, a longer Ambient setting or the undocumented system-default component timeout can land near half an hour.This change:
loopoff, seeks to 0 and plays again onended, and restarts if the playhead stallslifespan = "permanent"and a one-yeartimeout-secsin the manifest, and the same throughTimeoutManagerIt does not stop
power-service-core→forceDisplayOffwhen Ambient mode is off. That still needs a device log. The steps are indocs/vega-os-notes.md.Checks
pnpm typecheck && pnpm lint && pnpm test && pnpm format:checkpassespackages/wall-ui:pnpm tv:build:debugbuilds, and the wall still runs at/inpnpm web:dev— no Vega SDK in this environment, so the.vpkgwas not built. The web wall does not use this player.