Skip to content

test(event-ui): cover guest compose components - #18

Merged
ddedic merged 1 commit into
boothwall:mainfrom
Aditya-myst:test/issue-17-guest-compose
Oct 30, 2026
Merged

ddedic merged 1 commit into
boothwall:mainfrom
Aditya-myst:test/issue-17-guest-compose

Conversation

@Aditya-myst

Copy link
Copy Markdown
Contributor

What and why

Closes #17.

Adds focused Vitest and Testing Library coverage for the guest compose components:

  • SendBar: blocked-submit accessibility and behavior, ready submit behavior, and the sending label.
  • ConsentLine: accessible checkbox labelling and controlled toggling.
  • CategoryPicker: category change reporting and accessible checked state.

Checks

  • pnpm typecheck && pnpm lint && pnpm test && pnpm format:check passes

    • pnpm typecheck and pnpm lint pass.
    • pnpm --filter @boothwall/event-ui test passes: 32 files and 105 tests.
    • Prettier passes for all three changed files.
    • On Windows, the untouched repository-wide pnpm test fails in @boothwall/i18n generated-message path checks because of Windows path separators. Repository-wide pnpm format:check also reports untouched CRLF files.
  • No TV app or packages/wall-ui change.

  • Docs and screenshots are not applicable to this test-only change.

ddedic commented Oct 30, 2026

Copy link
Copy Markdown
Collaborator

hey, thanks a lot for this, first outside PR on the repo 🙌 tests look clean and cover everything from #17, ran them locally and all green. tiny optional thing: the consent test could match the actual label text instead of /./, but totally fine to leave it. merging, thanks again!

@ddedic
ddedic merged commit 2edb8d1 into boothwall:main Oct 30, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add tests for the guest compose form (SendBar, ConsentLine, CategoryPicker)

2 participants