Repository navigation
test(event-ui): cover guest compose components - #18
Merged
Merged
Conversation
Collaborator
|
hey, thanks a lot for this, first outside PR on the repo 🙌 tests look clean and cover everything from #17, ran them locally and all green. tiny optional thing: the consent test could match the actual label text instead of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Closes #17.
Adds focused Vitest and Testing Library coverage for the guest compose components:
SendBar: blocked-submit accessibility and behavior, ready submit behavior, and the sending label.ConsentLine: accessible checkbox labelling and controlled toggling.CategoryPicker: category change reporting and accessible checked state.Checks
pnpm typecheck && pnpm lint && pnpm test && pnpm format:checkpassespnpm typecheckandpnpm lintpass.pnpm --filter @boothwall/event-ui testpasses: 32 files and 105 tests.pnpm testfails in@boothwall/i18ngenerated-message path checks because of Windows path separators. Repository-widepnpm format:checkalso reports untouched CRLF files.No TV app or
packages/wall-uichange.Docs and screenshots are not applicable to this test-only change.