A minor cleanup and consolidation of the fedora version#94
Open
alicefr wants to merge 4 commits into
Open
Conversation
Collaborator
Author
|
/cc @HarshwardhanPatil07 can you please take a look? |
Clean-up the builder-bink intermediate stage since it isn't used. The release.yaml already build the stage directly to extract the bink binary, so this is a left over. Signed-off-by: Alice Frosi <afrosi@redhat.com>
Initially, we decided to put all the constants in defaults, but the versioning for the container images is quite complex and scattered in the code. Let's rely on the default argument on top of the Containerfile. Additionally, in this way, renovate can update the automatically the containerfiles. Bump also the version from 43 to 44. Signed-off-by: Alice Frosi <afrosi@redhat.com>
The fedora-minimal as based image for the dns one was always referring latest. Set the version to fedora 44 as the rest of the images. Signed-off-by: Alice Frosi <afrosi@redhat.com>
HarshwardhanPatil07
left a comment
HarshwardhanPatil07
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. You can bump this as well .github/workflows/build-node-image.yaml line no 47
container:
image: quay.io/fedora/fedora:43 <<<<
Bump the version from 43 to 44 for the container image for running the GHA. Signed-off-by: Alice Frosi <afrosi@redhat.com>
Collaborator
Author
Good catch! We should check if it is possible to let renovate bump this image version as well |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR simplify the versioning for the image. This should also fix the update of the dependecies #84 since it is bumping the go version which wasn't included in fedora 43 but it is in 44.