Skip to content

feat(ci): add CI tests - #1770

Closed
balazs-szucs wants to merge 66 commits into
booklore-app:developfrom
balazs-szucs:gh-actions-for-upstream
Closed

balazs-szucs wants to merge 66 commits into
booklore-app:developfrom
balazs-szucs:gh-actions-for-upstream

Conversation

@balazs-szucs

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
@github-advanced-security

Copy link
Copy Markdown

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@acx10

acx10 commented Dec 7, 2025

Copy link
Copy Markdown
Collaborator

@balazs-szucs Wow, that’s quite a bit going on. Do we actually need all of these pieces? We don’t even have this level of complexity at my company.

balazs-szucs and others added 6 commits December 7, 2025 10:07
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…d optimization

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…lysis configuration

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
@balazs-szucs

Copy link
Copy Markdown
Contributor Author

In the meantime, I opened this PR to mirror the final configuration state:

https://github.com/balazs-szucs/booklore/pull/42

@balazs-szucs Wow, that’s quite a bit going on. Do we actually need all of these pieces? We don’t even have this level of complexity at my company.

You are right, it is complex. Much of this workflow (though not all) was refined during my work with Stirling-PDF, and I wanted to bring those improvements here. I will add attributions to the files soon to credit the original contributors. Regarding licensing: my changes are substantial, and MIT is compatible with GPLv3.

Do we need it? Strictly speaking, no. However, since GitHub Actions usage is effectively unlimited for public open-source projects and the maintenance overhead is minimal, I believe the benefits outweigh the costs. If it catches even one bug, it’s worth having. I guess the only downside is the notification noise, but that can be turned off 😂

To be honest, I even planned to add more (mainly macOS testing), but life got in the way and I was getting frustrated with the testing 😂. This is a draft, though, I want you to feel comfortable with the changes. Please consider this a collaborative effort; I can (and will) adjust it to fit your vision if you have concrete feedback. But from my perspective, this is a solid baseline, and we will see where we go from here. E.g., target Java 25 for possible migration when they resolve stuff upstream, OS X builds, Tests with actual Books/PDFs (I didn't want to add binaries to this PR but a very much better way to test some stuff would be add them), etc...

balazs-szucs and others added 5 commits December 7, 2025 13:13
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…flow

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
… it is not ready yet

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
@balazs-szucs balazs-szucs added the ci CI/CD related changes label Dec 9, 2025
balazs-szucs and others added 14 commits December 10, 2025 22:49
…ntegrity check

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…s and Flyway configuration

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…rkflow

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…adb for improved compatibility

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…adb for improved compatibility

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…roved compatibility with MariaDB

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…ization order

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…ization order

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…flow

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…r e-ink devices

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…unt in CI

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
… API tests

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
… and jsonschema

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…s information

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Comment thread .github/workflows/advanced-testing-suite.yml Fixed
Comment thread .github/workflows/load-performance-tests.yml Fixed
balazs-szucs and others added 18 commits December 13, 2025 13:01
…iables and improved error handling

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…ce E-Ink visual regression handling

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…g and improved readiness checks

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…-tests.yml

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…ns for existing workflows

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…cks for Lighthouse audits

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…lysis tests for revision

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…ests

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…ng in persistence tests

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…ns and adjusting triggers

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
… files

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
- Remove eink-visual-regression.yml
- Remove E-Ink test references from advanced-testing-suite.yml
… tests

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
… workflow

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
…clarity

Signed-off-by: Balázs Szücs <bszucs1209@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci CI/CD related changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants