Repository navigation
Conversation
…longer discard its review The ACP panel client compared the whole git status text before and after a seat, so any new file, including the bundled skills Codex writes under skills/system/ at session start, exited 4 and discarded the review. It now compares per path with untracked files listed one by one, leaves out untracked files under skills/system/ in the launch directory, names up to ten changed paths in the log, and treats a failed status inside a checkout as a change. Same approach as chief-of-staff c72a0fc1.
…UTF-8 names as bytes in the log, isolate the test fixture commit
…to isolate the rename fixture's git on Windows
…T_DIR, reject a different repository at the end, isolate the fixture's init and hooks
…trol characters in a changed path are written as \xNN
Owner
Author
|
Pushed 874419b. Review 3 posted no findings, but from review 3 on the bot reports only high findings, and this client handles file names a seat controls, so I read the final diff by hand and found two defects: a missing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ACP panel client (
hr-code-review) exits 4 and discards a review whengit statusdiffers between launch and the end of a seat. It compared the whole--porcelaintext, so any new file counted, including the bundled skills Codex writes underskills/system/when a session starts. A Terra-max review of setupLinuxHost#1810 was discarded this way on 2026-11-03 because Codex wrote an untrackedskills/system/run-workflow/SKILL.md.This ports the fix from chief-of-staff
c72a0fc1(#836) into the single-file client:-z --untracked-files=alland compared per path. Untracked files underskills/system/in the launch directory (resolved withgit rev-parse --show-prefix) are not counted. A tracked change there, and a file that existed at launch and is gone at the end, still count.A seat's own new file under
skills/system/still goes undetected;references/acp-client.mdsays so.Checks:
bun run check, andGIT_CONFIG_GLOBAL=/dev/null GIT_CONFIG_SYSTEM=/dev/null bun test test skills(969 pass, 19 skip, 0 fail). The nine new tests inacp-client.test.mjsuse real Git; the three for the review's findings fail on the first draft. The Windows job was not run locally: the new file names avoid characters Windows rejects, and the invalid-UTF-8 test runs on Linux only.The setupLinuxHost pin adoption of the new revision is separate.