Skip to content

test(module-builder): expect the unprefixed marketplace name - #120

Open
LizunovSergey wants to merge 1 commit into
bmad-code-org:mainfrom
LizunovSergey:fix/119-marketplace-test-prefix
Open

LizunovSergey wants to merge 1 commit into
bmad-code-org:mainfrom
LizunovSergey:fix/119-marketplace-test-prefix

Conversation

@LizunovSergey

@LizunovSergey LizunovSergey commented Oct 3, 2026 •

Copy link
Copy Markdown

What

test_marketplace_json_content now expects the module code (exc) as the marketplace and plugin name. That is what the scaffold has written since f44073d.

Why

f44073d reserved the bmad- prefix for official BMad creations, so scaffold-standalone-module.py stopped prefixing the name. The test still expected bmad-exc, so it fails on main.
Fixes #119

How

  • The two name assertions change from bmad-exc to exc. The scaffold itself is unchanged.

Testing

Ran uv run tests/test-scaffold-standalone-module.py in skills/bmad-module-builder/scripts: 9 passed (on main: 8 passed, 1 failed). With the old bmad- prefix put back into the scaffold, the test fails again. The other test scripts under skills/ and samples/ already pass on main.

Summary by CodeRabbit

  • Tests
    • Updated the marketplace-content test to expect marketplace and plugin names to match the supplied module code.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 2ef97b88-d001-40e9-b103-8775c1807ee0
📥 Commits

Reviewing files that changed from the base of the PR and between d4a921c and 5d8d162.

📒 Files selected for processing (1)
  • skills/bmad-module-builder/scripts/tests/test-scaffold-standalone-module.py

Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review.


Walkthrough

The marketplace-content test now expects the marketplace and plugin names to equal the supplied module code, exc, instead of bmad-exc.

Changes

Standalone module test

Layer / File(s) Summary
Marketplace name expectations
skills/bmad-module-builder/scripts/tests/test-scaffold-standalone-module.py
The test expects both marketplace and plugin names to be exc.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other · Severity of issue fixed: Low

Merge Risk: ⚪ Minimal · up to 5d8d1

The test now matches the names the scaffold generates, so no merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the test change to expect the unprefixed marketplace name.
Linked Issues check ✅ Passed Issue #119 requires both name assertions in test_marketplace_json_content to expect exc. The reviewed test asserts marketplace["name"] == "exc" and plugin["name"] == "exc".
Out of Scope Changes check ✅ Passed The change summary reports only the two name-assertion updates in the test for issue #119. The reviewed file confirms both assertions. No unrelated change is evident.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

A rabbit checks the names at play,
And finds the prefix tucked away.
“exc” now matches what scaffolds write,
Two tests align, their values right.
The burrow rests in calm delight.

Comment @coderabbitai help to get the list of available commands.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_marketplace_json_content still expects the bmad- prefix that f44073d4 removed

1 participant