Repository navigation
test(module-builder): expect the unprefixed marketplace name - #120
LizunovSergey wants to merge 1 commit into
Conversation
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (1)
Included review availability: This review used your included allowance. Your plan provides up to 2 included reviews per hour; 1 remain after this review. WalkthroughThe marketplace-content test now expects the marketplace and plugin names to equal the supplied module code, ChangesStandalone module test
Priority: ⬇️ Low Estimated code review effort: 1 (Trivial) | ~5 minutes Change: Other · Severity of issue fixed: Low Merge Risk: ⚪ Minimal · up to The test now matches the names the scaffold generates, so no merge-blocking risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. A rabbit checks the names at play, Comment |
What
test_marketplace_json_contentnow expects the module code (exc) as the marketplace and plugin name. That is what the scaffold has written since f44073d.Why
f44073d reserved the
bmad-prefix for official BMad creations, soscaffold-standalone-module.pystopped prefixing the name. The test still expectedbmad-exc, so it fails onmain.Fixes #119
How
nameassertions change frombmad-exctoexc. The scaffold itself is unchanged.Testing
Ran
uv run tests/test-scaffold-standalone-module.pyinskills/bmad-module-builder/scripts: 9 passed (onmain: 8 passed, 1 failed). With the oldbmad-prefix put back into the scaffold, the test fails again. The other test scripts underskills/andsamples/already pass onmain.Summary by CodeRabbit