Skip to content

refactor(skills): cut boilerplate and dead conventions from rendered workflows - #3061

Merged
alexeyv merged 4 commits into
devfrom
refactor/trim-rendered-workflow-conventions
Oct 6, 2026
Merged

alexeyv merged 4 commits into
devfrom
refactor/trim-rendered-workflow-conventions

Conversation

@alexeyv

@alexeyv alexeyv commented Oct 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Stacked on #3060; merge that first. GitHub retargets this PR to dev when its base merges.

Four commits, each deleting prose the agent no longer needs on every run:

  • Cut the boilerplate from bmad-code-review/workflow.md. The goal paragraph, the snapshot warning, the architecture block, the step-processing and critical-rules lists, and the three activation sub-headings are gone. The workflow now says what the reviewers do, keeps the subagent instruction, and lists two conventions.
  • Define {project-root} in SKILL.md, where it is first resolved. The four rendered skills and the toolsmith template say it is the nearest folder containing _bmad/, from the working directory upward, next to the command that uses it. The duplicate definition in each workflow.md is removed.
  • Drop the {date} definition. Its uses make its meaning obvious.
  • Drop the absolute-path convention. Every cross-file reference in a rendered snapshot is already an absolute path the agent can see; the rule had nothing left to guard.

Verification

  • uv run tools/validate_skills.py --strict: zero findings.
  • uv run --frozen python -B -m pytest: passes.
  • bmad-code-review rendered in a worktree: the trimmed workflow comes out with no leaked tokens.

@greptile-apps

greptile-apps Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Documentation and workflow instruction text refactored.

The PR appears safe to merge; no actionable regression was identified.

Summary

The PR moves project-root discovery guidance to skill entry points and removes repeated conventions and workflow boilerplate.

  • The code-review workflow retains its activation order and first-step link.
  • Rendered cross-file references remain backed by the renderer.

Reviews (1) · Last reviewed commit: "docs(skills): drop the absolute-path con..."

@alexeyv
alexeyv force-pushed the feat/render-initiative-folder branch from abed7ea to 2630aab Compare October 6, 2026 16:14
Base automatically changed from feat/render-initiative-folder to dev October 6, 2026 16:15
@alexeyv
alexeyv force-pushed the refactor/trim-rendered-workflow-conventions branch from d4a968c to 34e0367 Compare October 6, 2026 16:24
@alexeyv
alexeyv merged commit 2fb99ed into dev Oct 6, 2026
3 checks passed
@alexeyv
alexeyv deleted the refactor/trim-rendered-workflow-conventions branch October 6, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant