Skip to content

reproduce and fix race condition push_clnt_cols, and l_send_back_row - #6087

Open
rishitha957 wants to merge 1 commit into
bloomberg:mainfrom
rishitha957:emit_race
Open

reproduce and fix race condition push_clnt_cols, and l_send_back_row#6087
rishitha957 wants to merge 1 commit into
bloomberg:mainfrom
rishitha957:emit_race

Conversation

@rishitha957

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread lua/sp.c
return luaL_error(L, "attempt to change number of columns");
}
if (num_cols < parent->ntypes) {
for (int i = num_cols - 1; i < parent->ntypes; ++i) {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is an existing bug (i think this is when we shrink columns to a lower count, we should free only from num_cols .. )

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
comdb2sys_pagesize_generated [db unavailable at finish]
sc_resume_logicalsc_generated **quarantined**
sc_resume
consumer_non_atomic_default_consumer_generated **quarantined**
tunables
sc_downgrade [timeout] **quarantined**
sp_twofiles_generated [timeout]
sp_snapshot_generated [timeout]
sp_queueodh_generated [timeout]

Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.net>

fix failing tests, add tunable to the tunables.test

Signed-off-by: Rishitha Kalicheti <rkalicheti1@bloomberg.net>

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants