Skip to content

{183854930} Default ruleset for system-generated SQL - #5886

Open
mponomar wants to merge 2 commits into
bloomberg:mainfrom
mponomar:no-strict-double-quotes-for-rulesets
Open

{183854930} Default ruleset for system-generated SQL#5886
mponomar wants to merge 2 commits into
bloomberg:mainfrom
mponomar:no-strict-double-quotes-for-rulesets

Conversation

@mponomar

Copy link
Copy Markdown
Contributor

No description provided.

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch from 2f3ef9d to 4c5662c Compare April 22, 2026 18:59
roborivers

This comment was marked as outdated.

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch 3 times, most recently from 45a7a16 to 58b557a Compare April 23, 2026 18:59
roborivers

This comment was marked as outdated.

roborivers

This comment was marked as outdated.

roborivers

This comment was marked as outdated.

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch from 406532c to 4cea99d Compare April 24, 2026 17:52
roborivers

This comment was marked as outdated.

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch 2 times, most recently from 581964d to cfc8b40 Compare May 4, 2026 16:03
roborivers

This comment was marked as outdated.

roborivers

This comment was marked as outdated.

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch from cfc8b40 to b257c57 Compare May 5, 2026 13:31
roborivers

This comment was marked as outdated.

roborivers

This comment was marked as outdated.

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch 3 times, most recently from d5203a0 to 5c16bc7 Compare May 6, 2026 15:27
@mponomar mponomar changed the title {183854930} remove strict double quotes as a prerequisite for rulesets with fingerprints {183854930} Default ruleset for system-generated SQL May 6, 2026

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
cldeadlock
reco-ddlk-sql **quarantined**
ruleset
consumer_non_atomic_default_consumer_generated **quarantined**
truncatesc_offline_generated [timeout] **quarantined**

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
sc_timepart **quarantined**
sc_resume
triggersc_latency
ruleset
consumer_non_atomic_default_consumer_generated **quarantined**
remtran_origin
reco-ddlk-sql [timeout] **quarantined**

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch from 5c16bc7 to 5a7c6fc Compare May 13, 2026 12:55

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
remsqltimeout [db unavailable at finish]
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
truncatesc_offline_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
sc_truncate_lockorder_generated [timeout] **quarantined**
reco-ddlk-sql [timeout] **quarantined**
sql_logfill_autodisable [timeout]

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
reco-ddlk-sql **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
remotecreate
remotecreate_twopc_generated

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart_multiddl_generated
consumer_non_atomic_default_consumer_generated **quarantined**

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch 2 times, most recently from 789b5ff to 2ee714e Compare June 4, 2026 14:22
@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch 3 times, most recently from 693434f to 26cf068 Compare June 4, 2026 18:10

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
consumer_non_atomic_default_consumer_generated **quarantined**
reco-ddlk-sql [timeout] **quarantined**

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch from 26cf068 to 301ae7c Compare June 8, 2026 15:53

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
consumer_non_atomic_default_consumer_generated **quarantined**

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**
sc_redo_logicalsc_generated [timeout]

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_redo [failed with core dumped]
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_truncate [db unavailable at finish]
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
osql_cleanup [failed with core dumped]
queuedb_rollover **quarantined**
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**
sc_truncate_lockorder_generated [timeout] **quarantined**

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch from 301ae7c to 5dcc28a Compare June 29, 2026 18:35

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Success ✓.
Regression testing: Success ✓.

The first 10 failing tests are:
sirace [failed with core dumped]
sc_force [failed with core dumped]
rebuild_table_options [failed with core dumped]
odh_blobs [failed with core dumped]
verify_writes [failed with core dumped]
sicountbug [failed with core dumped]
serial_randtest2 [failed with core dumped]
incremental_backup [failed with core dumped]
maxtable
phys_rep_tiered

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch from 5dcc28a to 577f437 Compare June 30, 2026 18:39

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_resume_logicalsc_generated **quarantined**
ssl_san
consumer_non_atomic_default_consumer_generated **quarantined**
ssl_set_cmd
ssl_prefer
ssl_dbname
sc_downgrade [timeout] **quarantined**

@SChakravorti21 SChakravorti21 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the ruleset docs still mention that strict double quotes are required for fingerprint rules - should the docs be updated with this change?

Comment thread bbinc/comdb2_ruleset.h Outdated
Comment thread tests/ruleset.test/t02.req.out
Comment thread sqlite/ext/comdb2/ruleset.c
Comment thread db/sql.h
Comment thread db/sqlpool.c
Comment thread db/sqlinterfaces.c

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_truncate_multiddl_generated [db unavailable at finish] **quarantined**
sc_resume
consumer_non_atomic_default_consumer_generated **quarantined**
sc_downgrade [timeout] **quarantined**

@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch from 4d74f98 to 6d7dbde Compare July 24, 2026 12:52

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: 0/0 tests failed ⚠.

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
sc_timepart [failed with core dumped] **quarantined**
sc_resume_logicalsc_generated **quarantined**
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys **quarantined**
ssl_san
replay_eventlog
consumer_non_atomic_default_consumer_generated **quarantined**
eventlog
builtin_ruleset

@roborivers roborivers left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cbuild submission: Error ⚠.
Regression testing: Success ✓.

The first 10 failing tests are:
logfill [db unavailable at finish] **quarantined**
truncatesc_offline_generated **quarantined**
sc_resume_logicalsc_generated **quarantined**
comdb2sys_queueodh_generated
comdb2sys_pagesize_generated
comdb2sys **quarantined**
replay_eventlog
consumer_non_atomic_default_consumer_generated **quarantined**
eventlog
builtin_ruleset

@@ -0,0 +1,5 @@
version 2

# sql_logfill - select lsn, generation, payload from comdb2_transaction_logs(?, ?, ?, ?)",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stray comment?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this file needed? sorry I struggled to figure out where/how it's used

@@ -0,0 +1,18 @@
version 2
pool system threads 32

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more for my own curiosity: after the db loads the ruleset, is there a way to increase the max number of threads in the pool at runtime?

…s with fingerprints

 * more visibility into rulesets
 * add identity as match criteria for rulesets
 * routines to load rulesets from a buffer.
 * expose gbl_ruleset for plugins
 * don't count queries in non-default pool towards service time metrics

signed-off-by: Mike Ponomarenko <mponomarenko@bloomberg.net>
@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch 2 times, most recently from 0bf09d7 to 8e4e9f2 Compare July 30, 2026 12:39
Includes statements run by the database itself and some common
utilities. These will run in a different threadpool.

Signed-off-by: Mike Ponomarenko <mponomarenko@bloomberg.net>
@mponomar
mponomar force-pushed the no-strict-double-quotes-for-rulesets branch from 8e4e9f2 to 60116d4 Compare July 30, 2026 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants